Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to process ocean/ice products specific to GEFS #2561
Add ability to process ocean/ice products specific to GEFS #2561
Changes from 36 commits
eb8a425
a6d31ba
16dc2e3
c2b4a58
c4d21dc
069cd86
a93bb34
31042bc
c6c24a9
79ebe1f
340f063
b52a999
66d5d3d
c5dc3ef
40a3151
6beb701
d7db8f3
3a94a24
422c896
19951d6
f85e432
d33f25b
0ad3e6a
b4d438e
90fd4cb
5a3729f
35e3158
c3ef547
275d153
e7c4e8f
2546f23
84ac5f1
5e1ab1f
4751f40
384e65c
14affd3
28696d9
6977691
47c4857
8cb9591
5318a44
e79f777
2978366
9171839
cbe6e8e
857b2c3
0e4d2b0
8b42d22
a79a640
e9ca884
6e01550
00320be
5935729
0b6a7e0
efd5dc7
7861646
6d8eca1
3ec2603
b8ab991
fc92340
563a613
1f1a84c
e3ea1ab
4edcafb
e4d6d36
8fdbdc1
82ee90b
50dfd3f
a3b8f03
b3b8748
7583e68
80858bc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason not to use the GFS settings for decomposition? Those seem to be fine and the only additional thing GEFS does is stochastic physics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EricSinsky-NOAA
I just noticed this script was added after an approval review was made on this PR and it slipped from being reviewed.
The function implemented here is the
datadep
withage
that Rocoto already provides.Besides, this is completely hardwired for GEFS options.
The function is checking the age of a file.
The file happens to be a ice netcdf file.
We will need to implement this via the proper rocoto means of checking if a file exists and if it has been present for 2 mins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.