{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":427490742,"defaultBranch":"dev/gfdl","name":"MOM6","ownerLogin":"NOAA-GFDL","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2021-11-12T20:39:58.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/11219395?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716305136.0","currentOid":""},"activityList":{"items":[{"before":"c7d3268b65292e6cfcdca595cfbfb9d5f1d2f519","after":"8ecb2603119b8c9d4dee9ee6b174e1864415d1cc","ref":"refs/heads/dev/gfdl","pushedAt":"2024-05-28T19:45:45.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"adcroft","name":"Alistair Adcroft","path":"/adcroft","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5859571?s=80&v=4"},"commit":{"message":"CI: Fix FMS_COMMIT, remove FRAMEWORK\n\nThis patch fixes FMS_COMMIT and FMS_URL so that they are properly\nexported to ``ac/deps/Makefile`` and used in the .testing FMS build.\n\nIt also removes any references to the FRAMEWORK flag, which is no longer\nneeded to identify the FMS API.","shortMessageHtmlLink":"CI: Fix FMS_COMMIT, remove FRAMEWORK"}},{"before":"2b69f1e9816b6d7a0235326a6e67de500aeb419e","after":"c7d3268b65292e6cfcdca595cfbfb9d5f1d2f519","ref":"refs/heads/dev/gfdl","pushedAt":"2024-05-24T18:37:58.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"adcroft","name":"Alistair Adcroft","path":"/adcroft","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5859571?s=80&v=4"},"commit":{"message":".testing: Target build uses its own Makefile\n\nThe build/target/MOM6 rule was modified so that build/target is now a\nsymlink into build/target_codebase/.testing/build/symmetric.\n\nIn other words, build/target now uses the entire build system of\ntarget_codebase (i.e. the reference codebase) rather than borrowing from\nbits and pieces of the current codebase.\n\nThis should prevent potential false positives in future regression tests\nrelated to buildsystem changes.\n\nSeveral apparently unused blocks of rules and other content in\n.testing/Makefile have also been removed.","shortMessageHtmlLink":".testing: Target build uses its own Makefile"}},{"before":"1cf20b3e43a4f235eb6dba66e29497102e9c652b","after":"2b69f1e9816b6d7a0235326a6e67de500aeb419e","ref":"refs/heads/dev/gfdl","pushedAt":"2024-05-24T01:42:25.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"},"commit":{"message":"Bugfix for tracer advection diagnostic in symmetric memory mode\n- Fix logic so tracer advection diagnostics are computed correctly for symmetric memory mode","shortMessageHtmlLink":"Bugfix for tracer advection diagnostic in symmetric memory mode"}},{"before":"c1c32d217bb6b9568e63299ae66e1a3674ea37d9","after":"1cf20b3e43a4f235eb6dba66e29497102e9c652b","ref":"refs/heads/dev/gfdl","pushedAt":"2024-05-22T14:33:34.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"},"commit":{"message":"Better variables for updated masks in fill_miss_2d\n\n  Within fill_miss_2d, there are 2 sets of masked values used for remapping -\nmasked values in neighboring points in arbitrary units (with names like \"south\")\nand the updated valid mask with values of 0 or 1 (with names like \"gs\").  At one\npoint in the code, the former were being used where the latter were more\nappropriate.  This commit changes this to help with the understandability of the\ncode.\n\n  However, when the order of arithmetic is not specified with parentheses, the\nNvidia compiler is changing answers with this change of variables.  To avoid\nthis change in answers, this commit is only changing which variables are used\nwhen the answer_date is larger than 20190101 and the order of the sums are\nspecified with parentheses.  This commit also now moves the logical test for\nans_2018 outside of the i- and j- loops where non-zero values of a_chg are set.\n\n  All answers and output are bitwise identical.","shortMessageHtmlLink":"Better variables for updated masks in fill_miss_2d"}},{"before":"9f3da0be2c72334c01e481d142421a6c55c3b6ff","after":"c1c32d217bb6b9568e63299ae66e1a3674ea37d9","ref":"refs/heads/dev/gfdl","pushedAt":"2024-05-22T03:09:25.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"},"commit":{"message":"Replace USE_GRID_SPACE_DIAGNOSTIC_AXES with USE_INDEX_DIAGNOSTIC_AXES\n\n  - The old flag has been obsoleted. This will impact only a very small\n    number of users.","shortMessageHtmlLink":"Replace USE_GRID_SPACE_DIAGNOSTIC_AXES with USE_INDEX_DIAGNOSTIC_AXES"}},{"before":"83bc4a66f8ba658a16c651d67992d966a387ca32","after":"9f3da0be2c72334c01e481d142421a6c55c3b6ff","ref":"refs/heads/dev/gfdl","pushedAt":"2024-05-21T22:26:53.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"},"commit":{"message":"Fix minor issues","shortMessageHtmlLink":"Fix minor issues"}},{"before":"7a2a33b59d4ec29cad31b779279e9d53856a3ffe","after":"83bc4a66f8ba658a16c651d67992d966a387ca32","ref":"refs/heads/dev/gfdl","pushedAt":"2024-05-21T21:20:52.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"adcroft","name":"Alistair Adcroft","path":"/adcroft","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5859571?s=80&v=4"},"commit":{"message":"GitLab CI: Direct build directory to $HOME\n\nThis patch directs the compilation of GitLab regression test models to\nthe $HOME directory.\n\nThis is motivated by incredibly slow file access times on GFDL's GPFS\nfile system (F5), with the Nvidia builds taking a prohibitively long\ntime (around 4 hours).  Compiling in $HOME reduces Nvidia times to 15\nminutes, with similar reduction times in the other compilation.\n\nThis is achieved with only minimal changes to the build system.  Instead\nof creating `build/`, we create a dedicated directory in\n`$HOME/ci/$CI_PROJECT_ID/build` and a symbolic link to this directory in\nthe GPFS directory.  To support these builds, additional symlinks to\n`src/` and `ocean_only/` (for static builds) are also created, from\n$HOME and back into GPFS.\n\nOnce the job is completed, the temporary space in $HOME is deleted.\n\nThis patch should not be considered a permanent solution, it is only\nmeant to get us through a difficult period of testing.  Hopefully we can\nrevert this change in the near future.","shortMessageHtmlLink":"GitLab CI: Direct build directory to $HOME"}},{"before":null,"after":"7a2a33b59d4ec29cad31b779279e9d53856a3ffe","ref":"refs/heads/gfdl-to-main-2024-05-21","pushedAt":"2024-05-21T15:25:36.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"},"commit":{"message":"Use FMS1 for MacOS builds\n\n- Given a recent incompatibility with FMS2 and gfortan 14.1\n  we need to revert to FMS1 for the MacOS builds.","shortMessageHtmlLink":"Use FMS1 for MacOS builds"}},{"before":"7d322d2e4922048ddbdabb5e93a881ce990c3554","after":null,"ref":"refs/heads/gfdl-to-main-2024-05-16","pushedAt":"2024-05-20T19:41:04.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"}},{"before":"6272bbcdc670639f9508026da9b85698a3a29257","after":"7a2a33b59d4ec29cad31b779279e9d53856a3ffe","ref":"refs/heads/dev/gfdl","pushedAt":"2024-05-20T19:41:03.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"},"commit":{"message":"Use FMS1 for MacOS builds\n\n- Given a recent incompatibility with FMS2 and gfortan 14.1\n  we need to revert to FMS1 for the MacOS builds.","shortMessageHtmlLink":"Use FMS1 for MacOS builds"}},{"before":"6272bbcdc670639f9508026da9b85698a3a29257","after":"7d322d2e4922048ddbdabb5e93a881ce990c3554","ref":"refs/heads/gfdl-to-main-2024-05-16","pushedAt":"2024-05-19T03:42:12.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"},"commit":{"message":"Use FMS1 for MacOS builds\n\n- Given a recent incompatibility with FMS2 and gfortan 14.1\n  we need to revert to FMS1 for the MacOS builds.","shortMessageHtmlLink":"Use FMS1 for MacOS builds"}},{"before":null,"after":"6272bbcdc670639f9508026da9b85698a3a29257","ref":"refs/heads/gfdl-to-main-2024-05-16","pushedAt":"2024-05-16T19:33:04.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"},"commit":{"message":"Testing: Correct perf parsing of C++ output\n\nThis patch fixes errors in the parser of perf output.  Previously,\neach record was assumed to be separated by spaces, but this failed for\nmore generic records (usually from C++) which included signatures (such\nas `f(a, b)`) or templates (`f<a, b>`).  Nested constructs were also\npossible.\n\nThis is fixed by introducing a simple tokenizer which extracts <, (, and\nwhitespace from the output , then rebuilds the records by combining any\nwhitespace which appears inside of delimiters.\n\nThis patch should hopefully resolve the CI errors in GitHub Actions.","shortMessageHtmlLink":"Testing: Correct perf parsing of C++ output"}},{"before":"e25388369e0ce0254658a0513e009f39cf98c340","after":"6272bbcdc670639f9508026da9b85698a3a29257","ref":"refs/heads/dev/gfdl","pushedAt":"2024-05-15T18:16:39.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"adcroft","name":"Alistair Adcroft","path":"/adcroft","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5859571?s=80&v=4"},"commit":{"message":"Testing: Correct perf parsing of C++ output\n\nThis patch fixes errors in the parser of perf output.  Previously,\neach record was assumed to be separated by spaces, but this failed for\nmore generic records (usually from C++) which included signatures (such\nas `f(a, b)`) or templates (`f<a, b>`).  Nested constructs were also\npossible.\n\nThis is fixed by introducing a simple tokenizer which extracts <, (, and\nwhitespace from the output , then rebuilds the records by combining any\nwhitespace which appears inside of delimiters.\n\nThis patch should hopefully resolve the CI errors in GitHub Actions.","shortMessageHtmlLink":"Testing: Correct perf parsing of C++ output"}},{"before":"0c790f2dcb975f0aeae024bc8651cfa4096716cc","after":"e25388369e0ce0254658a0513e009f39cf98c340","ref":"refs/heads/dev/gfdl","pushedAt":"2024-05-14T03:10:52.000Z","pushType":"push","commitsCount":9,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"},"commit":{"message":"Merge branch 'main' into dev/gfdl","shortMessageHtmlLink":"Merge branch 'main' into dev/gfdl"}},{"before":"bb8a6533178533289b92847153ee0612aec1903c","after":"0c790f2dcb975f0aeae024bc8651cfa4096716cc","ref":"refs/heads/dev/gfdl","pushedAt":"2024-05-14T02:05:01.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"},"commit":{"message":"SAL: Explicitly allocate sht variable in SAL_CS\n\nFor reasons not entirely clear, deallocation of the RK2 control\nstructure caused a segmentation fault when compiled by Nvidia.  A deeper\ninvestigation suggested that the compiler was attempting to deallocate a\nnullified pointer during automatic cleanup of RK2->SAL->sht.  Apparently\ndeallocation of a NULL pointer is an error (even though free() is not\nsupposed to care).\n\nBy redefining `sht` as an allocatable component rather than a local\ncomponent of the SAL_CS instance, it seemed to satisfy the compiler that\nnothing was needed and the error went away.\n\nThere are still some lingering questions behind the cause of the\nsegfault, but for now I am going to put this under \"compiler bug\".\n\nThis patch also initializes some of the logical flags in the SAL_CS\ntype.  This is possibly unnecessary, but it is consistent with the\ngeneral rules of safety followed in other MOM6 derived types.","shortMessageHtmlLink":"SAL: Explicitly allocate sht variable in SAL_CS"}},{"before":"2ab885eddfc47fc0c8c0bae46bc61531104428d5","after":"129e1bda02d454fb280819d1d87ae16347fd044c","ref":"refs/heads/main","pushedAt":"2024-05-13T19:10:36.000Z","pushType":"push","commitsCount":20,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"},"commit":{"message":"Merge pull request #1623 from jiandewang/DEV-EMC-candidate-20240425\n\nremove compiling warning","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2264288798\" data-permission-text=\"Title is private\" data-url=\"https://github.com/mom-ocean/MOM6/issues/1623\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/mom-ocean/MOM6/pull/1623/hovercard\" href=\"https://github.com/mom-ocean/MOM6/pull/1623\">mom-ocean#1623</a> from jiandewang/DEV-EMC-candidate-2…"}},{"before":null,"after":"b5ca1723ba1ca1f7a3b56348d9a9fa2d522bb119","ref":"refs/heads/main_to_dev","pushedAt":"2024-05-13T19:07:55.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"},"commit":{"message":"Merge branch 'main' into merge_to_dev","shortMessageHtmlLink":"Merge branch 'main' into merge_to_dev"}},{"before":"93d9bb80f817367a1e578a15c3446d98234a4154","after":"bb8a6533178533289b92847153ee0612aec1903c","ref":"refs/heads/dev/gfdl","pushedAt":"2024-05-13T17:53:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"},"commit":{"message":"Add diags for east, north velocity components.\n\n- This is required for our BOEM-funded Arctic project. It needs\n  something similar for SIS2 as well.","shortMessageHtmlLink":"Add diags for east, north velocity components."}},{"before":"1829b7f4c302e8cd7621cb7936bfc7b6df7cd513","after":"93d9bb80f817367a1e578a15c3446d98234a4154","ref":"refs/heads/dev/gfdl","pushedAt":"2024-05-13T04:23:11.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"},"commit":{"message":"+(*)Fix USE_QG_LEITH_VISC = True reproducibility\n\n  This commit includes a series of changes that get MOM6 to reproduce across\nprocessor counts, layouts and restarts when USE_QG_LEITH_VISC = True and also to\nimplement related changes to the QG Leith code to be consistent with not making\nthe Boussinesq approximation when in non-Boussinesq mode.  These changes\ninclude:\n\n  - Adding a thermo_var_ptrs and a timestep argument to to the interfaces to\n    horizontal_viscosity, initialize_dyn_split_RK2 and initialize_dyn_split_RK2b\n\n  - Correcting a bug in the powers of H_subroundoff in the denominators of some\n    expressions for the effective thicknesses associated with interfaces,\n    thereby correcting some dimensionally inconsistencies in these expressions\n\n  - Adding the new publicly visible routine calc_QG_slopes\n\n  - Adding the arguments slope_x and slope_y to calc_QG_Leith_viscosity and\n    avoiding the use of the VarMix%slope_[xy] elements in that routine\n\n  - Using thickness_to_dz to consistently convert layer thicknesses to the\n    vertical distances across layers and provide this as an argument to\n    calc_QG_Leith_viscosity\n\n  - Determining vertical distances in calculating the vertical derivatives of\n    the slopes consistently with avoiding the Boussinesq approximation when in\n    non-Boussinesq mode\n\n  - Increasing some loop extents in calc_QG_Leith_viscosity\n\n  Note that several of the expansions of the halo sizes in updates or in some of\nthe calculations are not necessary if an extra halo update is included for\nslope_x and slope_y and dz after the calls to calc_QG_slopes and thickness_to_dz\nin horizontal_viscosity.  This extra halo update has also been included in a\ncomment for later reference.\n\n  This commit includes several changes to publicly visible interfaces, and it\nwill change answers with USE_QG_LEITH_VISC = True (which had previously\ntriggered a fatal error), but answers and output are bitwise identical in other\ncases.","shortMessageHtmlLink":"+(*)Fix USE_QG_LEITH_VISC = True reproducibility"}},{"before":"a200f5f3b31f2e2d1ee69880ace46b2c876c7e57","after":"1829b7f4c302e8cd7621cb7936bfc7b6df7cd513","ref":"refs/heads/dev/gfdl","pushedAt":"2024-05-08T19:28:27.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"adcroft","name":"Alistair Adcroft","path":"/adcroft","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5859571?s=80&v=4"},"commit":{"message":"Makedep: Better handling of parentheses\n\nThe makedep tool was updated to handle parentheses in preprocessor\nexpressions.\n\nThe expression `#if (defined a)` could not be parsed due to poor ad-hoc\nhandling of parentheses, making it impossible to build the AM2-based\ncoupled models with makedep,\n\nThe tool has has been significantly overhauled to include better overall\nunary operator support.\n\n* `defined` is now more of an operation than an exception, since it is\n   pushed to the stack like any other operator.\n\n* Parentheses are now handled as \"operators\", with `)` triggering an\n  operator stack push and `(` conducting the actual operation (in this\n  case simply returning the contents).\n\n* In order to handle the possibility of macros within parentheses,\n  macros are now evaluated only immediately before used in expressions,\n  rather than the instant they are first encountered.\n\nThis redesign has allowed for many edge cases to be consolidated into\nthe general purpose parser, greatly simplifying the code.","shortMessageHtmlLink":"Makedep: Better handling of parentheses"}},{"before":"efe1b4a9f038345ba2a799023171034a0046a462","after":"a200f5f3b31f2e2d1ee69880ace46b2c876c7e57","ref":"refs/heads/dev/gfdl","pushedAt":"2024-05-08T17:54:37.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"},"commit":{"message":"Added missing values for vector u2_bg(:) within set_viscous_ML\n\nVector u2_bg(:) was introduced in commit 6c44c5f38 (Fix for using\ntidal amplitude in determining the BBL thickness, 2024-04-04). It\nreplaces a scalar in set_viscous_ML, but was not defined, causing\ncrashes. This commit sets the values of u2_bg(:) to match those given\ngiven in set_viscous_BBL.","shortMessageHtmlLink":"Added missing values for vector u2_bg(:) within set_viscous_ML"}},{"before":"a3e9e1c9d7f2c263a802564077a133f8a78b30a1","after":"efe1b4a9f038345ba2a799023171034a0046a462","ref":"refs/heads/dev/gfdl","pushedAt":"2024-05-08T03:41:08.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"},"commit":{"message":"+Fix multiple bugs when MEKE_GM_SRC_ALT is True\n\n  Fix several bugs when MEKE_GM_SRC_ALT is True, including corrections to two\ndimensional rescaling factors, and optionally fix a bug that sets a limit only\non positive slopes but leaving negative slopes unlimited.  This bug is corrected\nwhen the new runtime parameter MEKE_GM_SRC_ALT_SLOPE_BUG is false.  Additionally\nthere is a new runtime parameter MEKE_GM_SRC_ANSWER_DATE that specifies the use\nof rotationally symmetric expressions for PE_release_h when it is set to\n20240601 or higher, but it should be noted that rotational symmetry also\nrequires that MEKE_GM_SRC_ALT_SLOPE_BUG is false.  Four new checksum calls were\nalso added to verify the correctness of the calculation of MEKE%GM_src when\nMEKE_GM_SRC_ALT and DEBUG are true.  By default, all answers are bitwise\nidentical but there are two new runtime parameters in some MOM_parameter_doc\nfiles.","shortMessageHtmlLink":"+Fix multiple bugs when MEKE_GM_SRC_ALT is True"}},{"before":"46fd6e6d658e5eee8d9166e4bf039254fcc70edb","after":"a3e9e1c9d7f2c263a802564077a133f8a78b30a1","ref":"refs/heads/dev/gfdl","pushedAt":"2024-05-07T01:44:57.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"},"commit":{"message":"(*)Revise 13 diagnostics for rotational symmetry\n\n  Refactored 10 diagnostics related to terms in the kinetic energy budgets and\n2 diagnostics of nonlinear relative-vorticity related accelerations to respect\nrotational symmetry.  These diagnostics are mathematically equivalent but will\nchange at roundoff due to changes in the order of arithmetic.  Only diagnostics\nare changed, and the solutions themselves are bitwise identical in all cases.","shortMessageHtmlLink":"(*)Revise 13 diagnostics for rotational symmetry"}},{"before":"25989ad0b8e6cb3aeb52fe0bc387aefa352afe32","after":"46fd6e6d658e5eee8d9166e4bf039254fcc70edb","ref":"refs/heads/dev/gfdl","pushedAt":"2024-05-03T14:16:26.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"},"commit":{"message":"+Rotationally symmetric KPP_smooth_BLD option\n\n  Added the option of using rotationally symmetric expressions in\nKPP_smooth_BLD().  This is enabled by setting the new runtime parameter\nKPP%ANSWER_DATE to a value of 20240501 or higher.  For now the default is to\nuse the older symmetry-breaking expressions, but the default value for\nKPP%ANSWER_DATE should be revised to use DEFAULT_ANSWER_DATE.  By default, all\nanswers are bitwise identical but there is a new entry in some\nMOM_parameter_doc files.","shortMessageHtmlLink":"+Rotationally symmetric KPP_smooth_BLD option"}},{"before":"4058462f14d3b6ca2d0ebca8bd59b3e4877967e6","after":"25989ad0b8e6cb3aeb52fe0bc387aefa352afe32","ref":"refs/heads/dev/gfdl","pushedAt":"2024-05-02T00:47:26.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"},"commit":{"message":"Allow ALE boundary extrapolation behaviour to differ at initialisation and in model run\n\nAdds INIT_BOUNDARY_EXTRAP parameter and function, so that REMAP_BOUNDARY_EXTRAP can just be used in the initialisation and not in the model dynamics, as required for an ice shelf in ALE mode.\r\n\r\nBackground:\r\nWhen an ice shelf is initialised in ALE mode, MOM_state_initialization first initialises the ocean thickness and T/S with topography, but without an ice shelf. It then calls the function trim_for_ice, which takes in input of the ice shelf pressure, and in turn calls cut_off_column_top which truncates the columns (and adds vanishing layers) to account for the pressure of the ice depressing the free surface. The output of this is a grid with the ice shelf boundary treated in a ALE z-coordinate fashion with vanishing layers at the surface, and @adcroft's upcoming changes will make T and S consistent to the grid. However, after adding the ice shelf, we still need to regrid and remap onto our desired ALE coordinate, for example sigma coordinates. This can be done with regrid_accelerate in MOM_state_initialization or by the block controlled by REMAP_AFTER_INITIALIZATION in MOM.F90\r\n\r\nWe want the initialisation to use boundary extrapolation in the remapping so that the boundary cells preserve the desired initialisation profile when remapped to their target coordinate. This is controlled by REMAP_BOUNDARY_EXTRAP, except this runtime parameter modifies the control structure for the dynamic part of the model run too, which is bad because it means extrema are not preserved in the ALE remapping and can lead to non-sensible values of tracers.\r\n\r\nChanges:\r\n\r\n* Added runtime parameter INIT_BOUNDARY_EXTRAP and set the ALE control structure to use that instead of REMAP_BOUNDARY_EXTRAP at first. The default of INIT_BOUNDARY_EXTRAP is REMAP_BOUNDARY_EXTRAP to preserve answers (though it is not recommended to use REMAP_BOUNDARY_EXTRAP during model dynamics...)\r\n * After ALE regrid/remap in MOM.F90 (final initialisation step using ALE), reset the boundary extrapolation flag in the ALE control structure to go back to REMAP_BOUNDARY_EXTRAP.\r\n\r\nThis PR combined with @adcroft's upcoming changes should make the initialisation of the ocean thickness and TS in an ALE ice shelf cavity perfect, when the new flag INIT_BOUNDARY_EXTRAP = True and old flag REMAP_BOUNDARY_EXTRAP = False.","shortMessageHtmlLink":"Allow ALE boundary extrapolation behaviour to differ at initialisatio…"}},{"before":"01b2ea9ba0aa7473a68270700e140e11bf01fd77","after":"4058462f14d3b6ca2d0ebca8bd59b3e4877967e6","ref":"refs/heads/dev/gfdl","pushedAt":"2024-04-30T03:15:07.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"},"commit":{"message":"Refactoring density integrals for efficiency\n\n  Refactored 4 routines (int_density_generic_pcm, int_density_generic_ppm,\nint_spec_vol_generic_pcm and int_spec_vol_generic_plm) in density integrals for\ngreater computational efficiency by doing fewer calls to the equation of state\nroutines but calculating entire rows of densities at subgrid locations with each\neach call, replicating what was already being done int_density_dz_generic_plm.\nTo accomplish this, a number of variables now use larger arrays than\npreviously.  The total computational cost of the non-Boussinesq pressure\ngradient force calculation was more than 50% greater with the previous code in\nsome tests.  All answers are bitwise identical.","shortMessageHtmlLink":"Refactoring density integrals for efficiency"}},{"before":"0efe83d7433ac8aa89636257c262446b19ef34b2","after":"01b2ea9ba0aa7473a68270700e140e11bf01fd77","ref":"refs/heads/dev/gfdl","pushedAt":"2024-04-23T19:54:21.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"},"commit":{"message":"Document units of 34 real variables in vertFPmix\n\n  Added standard-format unit descriptions for 34 real variables in comments in\nthe subroutine vertPFmix.  Another 6 comments were added noting dimensionally\ninconsistent expressions in vertFPmix.  Only comments are changed and all\nanswers are bitwise identical.","shortMessageHtmlLink":"Document units of 34 real variables in vertFPmix"}},{"before":"1c4d0dc886b720ffad55d8ef7d2c3ec342326b63","after":"0efe83d7433ac8aa89636257c262446b19ef34b2","ref":"refs/heads/dev/gfdl","pushedAt":"2024-04-22T23:45:15.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"},"commit":{"message":"Proto-type cricital latitude modification of Henyey\n\n- Adds maximum latitude above which to reduce the background diffusion\n  to the minimum value.","shortMessageHtmlLink":"Proto-type cricital latitude modification of Henyey"}},{"before":"f7a4491b5b5e3f08ebaa128cb15e2fcde9ba9d91","after":"1c4d0dc886b720ffad55d8ef7d2c3ec342326b63","ref":"refs/heads/dev/gfdl","pushedAt":"2024-04-20T15:15:34.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"},"commit":{"message":"Better document variable units in 3 user modules\n\n  Added descriptions or added or corrected the units in the descriptions of 72\nvariables in the Neverworld_initialization and basin_builder modules.  This\nincludes minor refactoring to avoid reusing scalar variables with completely\ndifferent units.  Also refactored tidal_bay_set_OBC_data by moving the\nmultiplication by rescaling factors at one point so that the units of a variable\nagree with their documented units.  All answers are bitwise identical.","shortMessageHtmlLink":"Better document variable units in 3 user modules"}},{"before":"6c44c5f3843928c9b7b22aa8178148b0bb36e8ca","after":"f7a4491b5b5e3f08ebaa128cb15e2fcde9ba9d91","ref":"refs/heads/dev/gfdl","pushedAt":"2024-04-19T02:20:03.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"marshallward","name":"Marshall Ward","path":"/marshallward","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/462315?s=80&v=4"},"commit":{"message":"Perf: Better error report for failed parsing\n\nPrint the line and its tokenization in parse_perf.py if the tokenization\nfails for any reason.  This is most likely to occur if the fourth token\nis not an integer.\n\nThis is possibly a platform-dependent issue, and not something easily\nreplicated on any machine we are using, so it is easier to simply\nintegrate it into the codebase.","shortMessageHtmlLink":"Perf: Better error report for failed parsing"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEVjqCvwA","startCursor":null,"endCursor":null}},"title":"Activity · NOAA-GFDL/MOM6"}