Repository navigation
Convert 28 static arrays into dynamic arrays - #921
Merged
Hallberg-NOAA merged 1 commit intoJul 9, 2025
Merged
Conversation
Hallberg-NOAA
added
the
refactor
Member
|
"...should never have been declared using these static memory macros...". These would only be static if using static memory mode? I'm not what the policy for static memory should be anymore - for debugging or speed...? |
adcroft
approved these changes
Jul 9, 2025
Converted 28 arrays from potentially static using the ALLOCABLE_ and ALLOC_ macros into dynamic arrays in three modules. This change reduces the static memory footprint of MOM6. These arrays are only ever used conditionally based on parameter settings, so they should never have been declared using these static memory macros. All answers are bitwise identical and there are no changes to any public interfaces.
Hallberg-NOAA
force-pushed
the
less_static_arrays
branch
from
July 9, 2025 21:52
5ce88fe to
cf33610
Compare
Member
Author
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/28075. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converted 28 arrays from potentially static using the
ALLOCABLE_andALLOC_()macros into dynamic arrays in three modules. This change reduces the static memory footprint of MOM6. These arrays are only ever used conditionally based on parameter settings, so they should never have been declared using these static memory macros. All answers are bitwise identical and there are no changes to any public interfaces.