Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Altitude always = 0.0 in evaluation logs #29

Closed
dnorgaard-usgs opened this issue Dec 19, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@dnorgaard-usgs
Copy link
Contributor

commented Dec 19, 2017

Altitude in evaluation logs are always showing up as 0.0 instead of actual altitudes. Not a big deal for ground-based measurements but will be a problem when doing airborne measurements.

@dnorgaard-usgs

This comment has been minimized.

Copy link
Contributor Author

commented Dec 21, 2017

The GPGGA sentence, where altitude is reported, was not getting read properly in GPS::Parse. Fixed it to read GPGGA and now it writes to evaluation log.

Note, now the time and location info is updated from GPGGA instead of GPRMC.

@dnorgaard-usgs dnorgaard-usgs self-assigned this Dec 21, 2017

dnorgaard-usgs added a commit to dnorgaard-usgs/MobileDOAS that referenced this issue Dec 22, 2017

@dnorgaard-usgs dnorgaard-usgs added the bug label Jan 4, 2018

@dnorgaard-usgs dnorgaard-usgs reopened this Feb 8, 2018

@dnorgaard-usgs

This comment has been minimized.

Copy link
Contributor Author

commented Feb 8, 2018

The fix applied assumed the order of sentence to be GPRCM and then GPGGA. This is not necessarily the case, as some GPS will spit out GPGGA first. The code does not break up the sentences before sending it to the GPS::Parse function, which was part of the reason why GPGGA was not being read previously. This needs to be fixed to do so.

dnorgaard-usgs added a commit that referenced this issue Feb 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.