Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReEvaluate traverse - fast computer will crash the program #19

Closed
dnorgaard-usgs opened this issue Dec 13, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@dnorgaard-usgs
Copy link
Contributor

commented Dec 13, 2017

When running a reevaluation on a fast, modern, computer then the program will crash due to an overflow of spectra to display.

See also NOVACProject/MobileDOAS#13

@dnorgaard-usgs

This comment has been minimized.

Copy link
Contributor Author

commented Jan 25, 2018

Carlos seemed to have encountered this problem. He has provided eval logs to try but so far I have not been able to reproduce. Perhaps depends on computer specs?

@dnorgaard-usgs

This comment has been minimized.

Copy link
Contributor Author

commented Feb 9, 2018

The 200ms delay may be insufficient for some data sets. A better solution would be to identify the underlying problem so that the delay is not necessary. Or, so far, it seems the longest delay necessary is 1000ms.

@dnorgaard-usgs dnorgaard-usgs reopened this Feb 9, 2018

@mattias42

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2018

I think I solved this by now. My suggestion for fix is in the MemoryIssueInvestigations branch

dnorgaard-usgs added a commit that referenced this issue Feb 26, 2018

dnorgaard-usgs referenced this issue in dnorgaard-usgs/NOVACProgram Mar 5, 2018

dnorgaard-usgs referenced this issue in dnorgaard-usgs/NOVACProgram Mar 12, 2018

dnorgaard-usgs added a commit that referenced this issue Mar 12, 2018

Merge pull request #38 from dnorgaard-usgs/master
reintroduce sleep time for #19
@dnorgaard-usgs

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2018

Mattias found another bug and fixed it, which seemed to help even more. There's a slight problem with updating the graphics in this case, so a slight delay (20ms) between scans is still there to help. Will close after confirmation from user testing.

@dnorgaard-usgs

This comment has been minimized.

Copy link
Contributor Author

commented Apr 13, 2018

So far I have not been able to get user support for adequate testing. I will close this for now and reopen if there are further reports of crashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.