Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AirloopHVAC:UnitarySystem heating only systems incorrectly size flow rate when using FlowPerHeatingCapacity method #5209

Conversation

Projects
None yet
8 participants
@rraustad
Copy link
Contributor

commented Sep 16, 2015

Addresses #4702
Corrects AirloopHVAC:UnitarySystem sizing when FlowPerCoolingCapacity or FlowPerHeatingCapacity are specified as the Cooling/Heating Supply Air Flow Rate Method.
Also fixes sizing issue with multi-speed coils. CapFT curve was not being used during sizing.

rraustad added some commits Sep 16, 2015

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into #4702
…-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity
@nrel-bot

This comment has been minimized.

Copy link

commented on 4ea8ec3 Sep 16, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-MacOS-10.9-clang: OK (1860 of 1867 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Sep 17, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - i386-Windows-7-VisualStudio-12: OK (1851 of 1873 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Sep 17, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - Win64-Windows-7-VisualStudio-12: OK (1851 of 1873 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Sep 17, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

Build Badge

This comment has been minimized.

Copy link

replied Sep 17, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1851 of 1873 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Sep 17, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (803 of 803 tests passed)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Sep 17, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1339 of 1339 tests passed)

Build Badge Test Badge Coverage Badge

rraustad added some commits Sep 17, 2015

Merge remote-tracking branch 'remotes/origin/develop' into #4702-Airl…
…oopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity
@nrel-bot

This comment has been minimized.

Copy link

commented on 3ec1754 Sep 17, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-MacOS-10.9-clang: OK (1867 of 1874 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Sep 17, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - i386-Windows-7-VisualStudio-12: OK (1873 of 1880 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Sep 17, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - Win64-Windows-7-VisualStudio-12: OK (1873 of 1880 tests passed)

Build Badge Test Badge

@nrel-bot

This comment has been minimized.

Copy link

commented on 45c336a Sep 17, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-MacOS-10.9-clang: OK (1867 of 1874 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Sep 17, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

Build Badge

This comment has been minimized.

Copy link

replied Sep 18, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (806 of 806 tests passed)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Sep 18, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1873 of 1880 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Sep 18, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - i386-Windows-7-VisualStudio-12: OK (1873 of 1880 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Sep 18, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - Win64-Windows-7-VisualStudio-12: OK (1873 of 1880 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Sep 18, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1344 of 1344 tests passed)

Build Badge Test Badge Coverage Badge

@nrel-bot

This comment has been minimized.

Copy link

commented on bfac314 Sep 18, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-MacOS-10.9-clang: OK (1867 of 1874 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Sep 18, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - Win64-Windows-7-VisualStudio-12: OK (1873 of 1880 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Sep 18, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - i386-Windows-7-VisualStudio-12: OK (1873 of 1880 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Sep 18, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1873 of 1880 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Sep 18, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

Build Badge

This comment has been minimized.

Copy link

replied Sep 18, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (806 of 806 tests passed)

Build Badge Test Badge Coverage Badge

@rraustad

This comment has been minimized.

Copy link
Contributor Author

commented Sep 19, 2015

It's not surprising the multi-speed coil example files show diff's. Sizing was incorrectly using CapFT to size the coil instead of MSCapFT.

rraustad added some commits Sep 21, 2015

Merge remote-tracking branch 'remotes/origin/develop' into #4702-Airl…
…oopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity

Conflicts:
	tst/EnergyPlus/unit/HVACUnitarySystem.unit.cc
@nrel-bot

This comment has been minimized.

Copy link

commented on a412acd Sep 21, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-MacOS-10.9-clang: OK (1869 of 1876 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Sep 21, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - i386-Windows-7-VisualStudio-12: OK (1875 of 1882 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Sep 21, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - Win64-Windows-7-VisualStudio-12: OK (1875 of 1882 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Sep 21, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1875 of 1882 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Sep 21, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

Build Badge

This comment has been minimized.

Copy link

replied Sep 21, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (808 of 808 tests passed)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Sep 21, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1346 of 1346 tests passed)

Build Badge Test Badge Coverage Badge

@mjwitte mjwitte added the Defect label Sep 21, 2015

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into #4702
…-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity

Conflicts:
	tst/EnergyPlus/unit/HVACUnitarySystem.unit.cc
@nrel-bot

This comment has been minimized.

Copy link

commented on 81560b0 Sep 22, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1876 of 1883 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Sep 22, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

Build Badge

This comment has been minimized.

Copy link

replied Sep 22, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (809 of 809 tests passed)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Sep 22, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1347 of 1347 tests passed)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Sep 22, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Oct 18, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - Win64-Windows-7-VisualStudio-12: Tests Failed

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Oct 19, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Oct 19, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

Build Badge

This comment has been minimized.

Copy link

replied Oct 19, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (809 of 809 tests passed)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Oct 19, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1347 of 1347 tests passed)

Build Badge Test Badge Coverage Badge

@nrel-bot

This comment has been minimized.

Copy link

commented Oct 6, 2015

@rraustad @lgentile it has been 14 days since this pull request was last updated.

1 similar comment
@nrel-bot

This comment has been minimized.

Copy link

commented Oct 20, 2015

@rraustad @lgentile it has been 14 days since this pull request was last updated.

rraustad added some commits Oct 26, 2015

Merge remote-tracking branch 'remotes/origin/develop' into #4702-Airl…
…oopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity

Conflicts:
	src/EnergyPlus/DXCoils.cc
	tst/EnergyPlus/unit/HVACUnitarySystem.unit.cc
Merge branch '#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for…
…-heating-only-systems-when-using-FlowPerHeatingCapacity' of https://github.com/NREL/EnergyPlus into #4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity

Conflicts:
	tst/EnergyPlus/unit/HVACUnitarySystem.unit.cc
@nrel-bot-3

This comment has been minimized.

Copy link

commented on 288b547 Oct 26, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-MacOS-10.9-clang: OK (1938 of 1954 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Oct 26, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1944 of 1960 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Oct 26, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

Build Badge

This comment has been minimized.

Copy link

replied Oct 26, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (886 of 886 tests passed)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Oct 26, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1424 of 1424 tests passed)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Oct 26, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - i386-Windows-7-VisualStudio-12: OK (1944 of 1960 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Oct 26, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - Win64-Windows-7-VisualStudio-12: OK (1944 of 1960 tests passed)

Build Badge Test Badge

Myoldmopar added some commits Oct 29, 2015

Merge remote-tracking branch 'origin/develop' into #4702-AirloopHVACU…
…nitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity
@Myoldmopar

This comment has been minimized.

Copy link
Member

commented Oct 29, 2015

@rraustad If you take a look at the Files Changed for this pull request, you'll see that DXCoils.cc has 884 lines added, 864 lines deleted. This means every line in the file was modified. This screams of a line ending problem.

My steps:

  • Check out this branch
  • Open src/EnergyPlus/DXCoils.cc in my text editor of choice. It recognizes that the file has my native (Linux) line endings. So far so good.
  • Search for Windows line endings -- none

Hmm. OK.

Next steps:

  • Merge develop into this branch (git fetch origin; git merge origin/develop)
  • Compare develop and this branch locally (git diff develop..'#4702reallylongbranchname')
  • Investigate the diffs.....looks like it is tab vs. space issue.

To Fix:

  • Back in text editor, change spaces to tabs
  • Commit and compare branches ... looks better, but not 100% confident.
  • Push up and let Github show me what it thinks the diffs look like (40a0a78)

There we go!! DXCoils now shows about 80 lines changed. Good to go.

@nrel-bot-3

This comment has been minimized.

Copy link

commented on 40a0a78 Oct 29, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1949 of 1956 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Oct 30, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1955 of 1962 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Oct 30, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1955 of 1962 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Oct 30, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

Build Badge

This comment has been minimized.

Copy link

replied Oct 30, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (888 of 888 tests passed)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Oct 30, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1955 of 1962 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Oct 30, 2015

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1426 of 1426 tests passed)

Build Badge Test Badge Coverage Badge

@nrel-bot

This comment has been minimized.

Copy link

commented Nov 13, 2015

@rraustad @lgentile it has been 14 days since this pull request was last updated.

1 similar comment
@nrel-bot-3

This comment has been minimized.

Copy link

commented Nov 27, 2015

@rraustad @lgentile it has been 14 days since this pull request was last updated.

Merge branch '#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for…
…-heating-only-systems-when-using-FlowPerHeatingCapacity' of https://github.com/NREL/EnergyPlus into #4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity

Conflicts:
	src/EnergyPlus/DXCoils.cc
@nrel-bot-3

This comment has been minimized.

Copy link

commented on 7b3df23 Jan 11, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rongpengzhang) - x86_64-MacOS-10.9-clang: Build Failed

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 11, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rongpengzhang) - i386-Windows-7-VisualStudio-12: Build Failed

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rongpengzhang) - Win64-Windows-7-VisualStudio-12: Build Failed

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Build Failed

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

This comment has been minimized.

Copy link

replied Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: Build Failed

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Build Failed

Build Badge Test Badge Coverage Badge

@rraustad

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2016

I think I got everything. I don't understand what is causing the error with ControlVRFIUCoil?

@nrel-bot-3

This comment has been minimized.

Copy link

commented on 4d28e1a Jan 11, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-MacOS-10.9-clang: OK (2044 of 2045 tests passed, 0 test warnings)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - i386-Windows-7-VisualStudio-12: OK (2050 of 2051 tests passed, 0 test warnings)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2081 of 2083 tests passed, 0 test warnings)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

This comment has been minimized.

Copy link

replied Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - Win64-Windows-7-VisualStudio-12: OK (2050 of 2051 tests passed, 0 test warnings)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (950 of 951 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1501 of 1502 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@rraustad

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2016

Must I really move this function to avoid this error? Why hasn't this happened before?

http://stackoverflow.com/questions/16290834/error-c3861-rolldice-identifier-not-found

Compiler goes through your files from the beginning till the end, meaning that the placement of the definition of your function matters. In this case, you can either move the definition of this function before it is used first time:

void rollDice()
{
...
}

void otherFunction()
{
// rollDice has been previously defined:
rollDice();
}
or you can use forward declaration to tell the compiler that such a function exists:

// function rollDice with the following prototype exists:
void rollDice();

void otherFunction()
{
// rollDice has been previously declared:
rollDice();
}

// definition of rollDice:
void rollDice()
{
...
}

@rongpengzhang

This comment has been minimized.

Copy link
Contributor

commented Jan 12, 2016

@rraustad At the beginning of each cc file, we include the corresponding hh file, such as DXCoil.hh. So we don't need to define functions in the cc file before it is first called.

I think I didn't update DXCoil.hh just now when I updated DXCoil.cc to solve the conflicts. I renamed function "CalcVRFIUAirFlow" to "ControlVRFIUCoil", so it should be updated in hh file.

Can you please delete the "CalcVRFIUAirFlow" defenition in DXCoil.hh, and paste the following:

void
ControlVRFIUCoil (
    int const CoilIndex,  // index to VRFTU coil 
    Real64 const QCoil,   // coil load
    Real64 const Tin,     // inlet air temperature
    Real64 const Win,     // inlet air humidity ratio
    Real64 const TeTc,    // evaporating or condensing temperature
    Real64 const OAMassFlow,  // mass flow rate of outdoor air 
    Real64 & FanSpdRatio, // fan speed ratio: actual flow rate / rated flow rate
    Real64 & Wout,    // outlet air humidity ratio
    Real64 & Tout, // outlet air temperature
    Real64 & Hout, // outlet air enthalpy
    Real64 & SHact,   // actual SH
    Real64 & SCact    // actual SC
);
@rraustad

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2016

There is no CalcVRFIUAirFlow in the hh file.
Should there be something else at the top of the hh or cc file?

DXCoils.hh

#ifndef DXCoils_hh_INCLUDED
#define DXCoils_hh_INCLUDED

// ObjexxFCL Headers
#include <ObjexxFCL/Array1D.hh>
#include <ObjexxFCL/Optional.hh>

// EnergyPlus Headers
#include <EnergyPlus.hh>
#include <DataGlobals.hh>
#include <DataHVACGlobals.hh>
#include <DataEnvironment.hh>

namespace EnergyPlus {
@rraustad

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2016

Sorry, that was DXCoils.hh. At the top of the cc file is

#include <cassert>
#include <cmath>
#include <string>

// ObjexxFCL Headers
#include <ObjexxFCL/Fmath.hh>
#include <ObjexxFCL/gio.hh>

// EnergyPlus Headers
#include <DXCoils.hh>
@nrel-bot-3

This comment has been minimized.

Copy link

commented on 75e6e09 Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-MacOS-10.9-clang: OK (2044 of 2045 tests passed, 0 test warnings)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2081 of 2083 tests passed, 0 test warnings)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

This comment has been minimized.

Copy link

replied Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (950 of 951 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - i386-Windows-7-VisualStudio-12: OK (2050 of 2051 tests passed, 0 test warnings)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - Win64-Windows-7-VisualStudio-12: OK (2050 of 2051 tests passed, 0 test warnings)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1501 of 1502 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-3

This comment has been minimized.

Copy link

commented on 12d88ad Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-MacOS-10.9-clang: OK (2044 of 2045 tests passed, 0 test warnings)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2082 of 2083 tests passed, 0 test warnings)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

This comment has been minimized.

Copy link

replied Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - i386-Windows-7-VisualStudio-12: OK (2050 of 2051 tests passed, 0 test warnings)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (951 of 951 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1502 of 1502 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Jan 12, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - Win64-Windows-7-VisualStudio-12: OK (2050 of 2051 tests passed, 0 test warnings)

Build Badge Test Badge

@rraustad

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2016

Only 1 diff now explained by change in sizing (fan heat now included for multispeed coil, see Dec 8 comment above)

@Myoldmopar

This comment has been minimized.

Copy link
Member

commented Jan 14, 2016

I made some very minor changes, formatting only. I guess I'll let CI take one more pass just to make sure I didn't break anything doing that, then this can merge. Thanks for all the effort in merging the work together.

@nrel-bot-3

This comment has been minimized.

Copy link

commented on 9a54643 Jan 14, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (2044 of 2045 tests passed, 0 test warnings)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 14, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2082 of 2083 tests passed, 0 test warnings)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 14, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

This comment has been minimized.

Copy link

replied Jan 14, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (951 of 951 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Jan 14, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1502 of 1502 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Jan 14, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (2050 of 2051 tests passed, 0 test warnings)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 14, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (2050 of 2051 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-3

This comment has been minimized.

Copy link

commented on e0f3631 Jan 14, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1921 of 2048 tests passed, 0 test warnings)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 14, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (2053 of 2054 tests passed, 0 test warnings)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 14, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1959 of 2086 tests passed, 0 test warnings)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 14, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

This comment has been minimized.

Copy link

replied Jan 14, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (954 of 954 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Jan 14, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1505 of 1505 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Jan 15, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1927 of 2054 tests passed, 0 test warnings)

Build Badge Test Badge

Merge remote-tracking branch 'origin/develop' into #4702-AirloopHVACU…
…nitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity
@Myoldmopar

This comment has been minimized.

Copy link
Member

commented Jan 14, 2016

Another pull up to develop....gosh, if @Myoldmopar would just stop merging other things in.....

@nrel-bot-3

This comment has been minimized.

Copy link

commented on 1df10bc Jan 14, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (2048 of 2049 tests passed, 0 test warnings)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 15, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2086 of 2087 tests passed, 0 test warnings)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 15, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

This comment has been minimized.

Copy link

replied Jan 15, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (955 of 955 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Jan 15, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1506 of 1506 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Jan 15, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (2054 of 2055 tests passed, 0 test warnings)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 15, 2016

#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (2054 of 2055 tests passed, 0 test warnings)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Jan 16, 2016

This comment has been minimized.

Copy link

replied Jan 16, 2016

Myoldmopar added a commit that referenced this pull request Jan 15, 2016

Merge pull request #5209 from NREL/#4702-AirloopHVACUnitarySystem-aut…
…osizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity

#4702 airloop hvac unitary system autosizing incorrect for heating only systems when using flow per heating capacity

@Myoldmopar Myoldmopar merged commit 7eaa017 into develop Jan 15, 2016

7 checks passed

Win64-Windows-7-VisualStudio-12 OK (2054 of 2055 tests passed, 0 test warnings)
Details
i386-Windows-7-VisualStudio-12 OK (2054 of 2055 tests passed, 0 test warnings)
Details
x86_64-Linux-Ubuntu-14.04-cppcheck-1.61 OK (0 of 0 tests passed, 0 test warnings)
Details
x86_64-Linux-Ubuntu-14.04-gcc-4.8 OK (2086 of 2087 tests passed, 0 test warnings)
Details
x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug OK (1506 of 1506 tests passed, 0 test warnings)
Details
x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug OK (955 of 955 tests passed, 0 test warnings)
Details
x86_64-MacOS-10.9-clang OK (2048 of 2049 tests passed, 0 test warnings)
Details

@Myoldmopar Myoldmopar deleted the #4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity branch Jan 15, 2016

@rraustad

This comment has been minimized.

Copy link
Contributor Author

commented Jan 15, 2016

😄 👍 👏

@rongpengzhang

This comment has been minimized.

Copy link
Contributor

commented Jan 15, 2016

👏

@Myoldmopar

This comment has been minimized.

Copy link
Member

commented Jan 15, 2016

🐧 🔆 🌀 👩 ↕️

@Myoldmopar

This comment has been minimized.

Copy link
Member

commented Feb 16, 2016

@rraustad Can you update the title of this PR so that it is more user-digestable in the auto-generated ChangeLog? Thanks!

@rraustad rraustad changed the title #4702 airloop hvac unitary system autosizing incorrect for heating only systems when using flow per heating capacity AirloopHVAC:UnitarySystem heating only systems incorrectly size flow rate when using FlowPerHeatingCapacity method Feb 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.