Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HeatExchanger:FluidToFluid with CoolingDifferentialOnOff stuck in off mode #5511

Merged
merged 5 commits into from Mar 3, 2016

Conversation

Projects
None yet
6 participants
@EnergyArchmage
Copy link
Contributor

commented Feb 26, 2016

Revised plant HX control logic to make use of FirstHVACIteration in cases where the control depends on the demand side inlet node temperature. Now, the HX may request flow on the demand side during FirstHVACIteration when temperatures are not favorable, so that the solver will update what the demand side inlet node temperature would be if the loop runs.

Addresses issue #4959

The change in control logic can be expected to trigger at least small differences in nearly all integration test files that have the plant HX. Typically the results are very close (becasue the test suite does not really include a file tha shows the defect) but the solutions cannot be expected to be exactly the same because the system iterations play out differently. Expect slightly slower performance because of the chance that plant will need another iteration.

The following files are expected to show diffs in CI.
5ZoneCoolBeam
FourPipeBeamLargeOffice
HospitalLowEnergy
PlantLoopChainCooling
PlantLoopChainDeadband
PlantLoopChainDualDeadband
PlantLoopChainHeating
WaterSideEconomizer_Integrated
WaterSideEconomizer_NonIntegrated

Carry FirstHVACIteration into Plant HX to un-stick demand side
Trial fix for issue 4959. Add FirstHVACIteration arguments to use
FirstHVACIteration in logic for setting demand side HX flow rate.  Fix
problem of no flow request not triggering any trial of what the demand
side loop could do were it to run.
@nrel-bot

This comment has been minimized.

Copy link

commented on bcf3920 Nov 28, 2015

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - i386-Windows-7-VisualStudio-12: OK (1965 of 1974 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Nov 28, 2015

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1965 of 1974 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Nov 28, 2015

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

Build Badge

This comment has been minimized.

Copy link

replied Nov 28, 2015

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (900 of 900 tests passed)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Nov 28, 2015

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1438 of 1438 tests passed)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Nov 28, 2015

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - Win64-Windows-7-VisualStudio-12: OK (1965 of 1974 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Dec 3, 2015

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - x86_64-MacOS-10.9-clang: OK (1939 of 1968 tests passed)

Build Badge Test Badge

@nrel-bot-3

This comment has been minimized.

Copy link

commented on 355631c Dec 15, 2015

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - x86_64-MacOS-10.9-clang: OK (1968 of 1978 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Dec 15, 2015

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - i386-Windows-7-VisualStudio-12: OK (1974 of 1984 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Dec 15, 2015

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - Win64-Windows-7-VisualStudio-12: OK (1974 of 1984 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Dec 15, 2015

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1974 of 1984 tests passed)

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Dec 15, 2015

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

Build Badge

This comment has been minimized.

Copy link

replied Dec 15, 2015

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (910 of 910 tests passed)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Dec 15, 2015

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1448 of 1448 tests passed)

Build Badge Test Badge Coverage Badge

@nrel-bot-2

This comment has been minimized.

Copy link

commented on d83c275 Feb 26, 2016

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

This comment has been minimized.

Copy link

replied Feb 26, 2016

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - x86_64-MacOS-10.9-clang: OK (2110 of 2116 tests passed, 547 test warnings)

  • 531 tests had: EIO diffs.
  • 4 tests had: ESO small diffs.
  • 1 test had: MTR small diffs.
  • 24 tests had: ERR diffs.
  • 6 tests had: ESO big diffs.
  • 4 tests had: Table big diffs.
  • 4 tests had: MTR big diffs.
  • 2 tests had: Table small diffs.

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Feb 26, 2016

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1008 of 1008 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Feb 26, 2016

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2147 of 2154 tests passed, 549 test warnings)

  • 534 tests had: EIO diffs.
  • 7 tests had: ESO big diffs.
  • 1 test had: MTR small diffs.
  • 5 tests had: Table big diffs.
  • 24 tests had: ERR diffs.
  • 3 tests had: ESO small diffs.
  • 4 tests had: MTR big diffs.
  • 2 tests had: Table small diffs.

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Feb 26, 2016

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

This comment has been minimized.

Copy link

replied Feb 26, 2016

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1566 of 1566 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Feb 26, 2016

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - i386-Windows-7-VisualStudio-12: OK (2115 of 2122 tests passed, 549 test warnings)

  • 534 tests had: EIO diffs.
  • 7 tests had: ESO big diffs.
  • 5 tests had: Table big diffs.
  • 24 tests had: ERR diffs.
  • 3 tests had: ESO small diffs.
  • 4 tests had: MTR big diffs.
  • 2 tests had: Table small diffs.

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Feb 26, 2016

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - Win64-Windows-7-VisualStudio-12: OK (2115 of 2122 tests passed, 549 test warnings)

  • 534 tests had: EIO diffs.
  • 7 tests had: ESO big diffs.
  • 5 tests had: Table big diffs.
  • 24 tests had: ERR diffs.
  • 3 tests had: ESO small diffs.
  • 4 tests had: MTR big diffs.
  • 2 tests had: Table small diffs.

Build Badge Test Badge

@nrel-bot-2

This comment has been minimized.

Copy link

commented on d0f7264 Feb 26, 2016

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

This comment has been minimized.

Copy link

replied Feb 26, 2016

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - x86_64-MacOS-10.9-clang: OK (2116 of 2121 tests passed, 4 test warnings)

  • 4 tests had: EIO diffs.
  • 4 tests had: ESO small diffs.
  • 1 test had: MTR small diffs.
  • 2 tests had: ERR diffs.
  • 5 tests had: ESO big diffs.
  • 4 tests had: Table big diffs.
  • 4 tests had: MTR big diffs.
  • 2 tests had: Table small diffs.

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Feb 26, 2016

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1013 of 1013 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Feb 26, 2016

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

This comment has been minimized.

Copy link

replied Feb 26, 2016

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2153 of 2159 tests passed, 3 test warnings)

  • 4 tests had: EIO diffs.
  • 6 tests had: ESO big diffs.
  • 1 test had: MTR small diffs.
  • 5 tests had: Table big diffs.
  • 2 tests had: ERR diffs.
  • 3 tests had: ESO small diffs.
  • 4 tests had: MTR big diffs.
  • 2 tests had: Table small diffs.

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Feb 26, 2016

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1571 of 1571 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

This comment has been minimized.

Copy link

replied Feb 26, 2016

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - Win64-Windows-7-VisualStudio-12: OK (2120 of 2127 tests passed, 3 test warnings)

  • 4 tests had: EIO diffs.
  • 3 tests had: ESO small diffs.
  • 1 test had: MTR small diffs.
  • 2 tests had: ERR diffs.
  • 6 tests had: ESO big diffs.
  • 4 tests had: Table big diffs.
  • 4 tests had: MTR big diffs.
  • 2 tests had: Table small diffs.

Build Badge Test Badge

This comment has been minimized.

Copy link

replied Feb 26, 2016

4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - i386-Windows-7-VisualStudio-12: OK (2121 of 2127 tests passed, 3 test warnings)

  • 4 tests had: EIO diffs.
  • 6 tests had: ESO big diffs.
  • 5 tests had: Table big diffs.
  • 2 tests had: ERR diffs.
  • 3 tests had: ESO small diffs.
  • 4 tests had: MTR big diffs.
  • 2 tests had: Table small diffs.

Build Badge Test Badge

@mjwitte mjwitte added the Defect label Mar 2, 2016

@mjwitte mjwitte changed the title 4959 plant hx cooldifferential stuck off Fix HeatExchanger:FluidToFluid with CoolingDifferentialOnOff stuck in off mode Mar 2, 2016

@Myoldmopar

This comment has been minimized.

Copy link
Member

commented Mar 3, 2016

Code changes look fine. Transitioned up the defect file and ran it with develop and this, and it looks good. Merging this. Thanks @EnergyArchmage.

Myoldmopar added a commit that referenced this pull request Mar 3, 2016

Merge pull request #5511 from NREL/4959-plant-HX-CoolDifferential-stu…
…ck-Off

Fix HeatExchanger:FluidToFluid with CoolingDifferentialOnOff stuck in off mode

@Myoldmopar Myoldmopar merged commit 4104adf into develop Mar 3, 2016

8 checks passed

Win64-Windows-7-VisualStudio-12 OK (2120 of 2127 tests passed, 3 test warnings)
Details
i386-Windows-7-VisualStudio-12 OK (2121 of 2127 tests passed, 3 test warnings)
Details
x86_64-Linux-Ubuntu-14.04-cppcheck-1.61 OK (0 of 0 tests passed, 0 test warnings)
Details
x86_64-Linux-Ubuntu-14.04-custom_check OK (0 of 0 tests passed, 0 test warnings)
Details
x86_64-Linux-Ubuntu-14.04-gcc-4.8 OK (2153 of 2159 tests passed, 3 test warnings)
Details
x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug OK (1571 of 1571 tests passed, 0 test warnings)
Details
x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug OK (1013 of 1013 tests passed, 0 test warnings)
Details
x86_64-MacOS-10.9-clang OK (2116 of 2121 tests passed, 4 test warnings)
Details

@Myoldmopar Myoldmopar deleted the 4959-plant-HX-CoolDifferential-stuck-Off branch Mar 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.