Change test tank height for heaters in stratified water heater

[Myoldmopar]

This just changes which height to use in checking whether the heaters are out of range. I didn't do a deep inspection of the whole module, but the defect file now runs to completion with a clean error file, so I think this is good to go. Fixes: #5635

[Myoldmopar]

@mjwitte I put you down to review, but if you are out of time, I can handle it. The defect file from the issue now runs successfully though.

[JasonGlazer]

@Myoldmopar When running the unit tests locally, EnergyPlusFixture.HPWHWrappedDummyNodeConfig fails as well as EnergyPlusFixture.StratifiedTankUseEnergy

[Myoldmopar]

Yeah, I saw the failures come through, I'll take a look in a bit. Can you post the failure output?

[JasonGlazer]

[ RUN ] EnergyPlusFixture.HPWHEnergyBalance
........\tst\EnergyPlus\unit\WaterThermalTanks.unit.cc(734): error: Value of: WaterThermalTanks::GetWaterThermalTankInput()
Actual: true
Expected: false
[ FAILED ] EnergyPlusFixture.HPWHEnergyBalance (13131 ms)

[ RUN ] EnergyPlusFixture.StratifiedTankUseEnergy
........\tst\EnergyPlus\unit\WaterThermalTanks.unit.cc(1592): error: Value of: WaterThermalTanks::GetWaterThermalTankInputData( ErrorsFound )
Actual: true
Expected: false
[ FAILED ] EnergyPlusFixture.StratifiedTankUseEnergy (8177 ms)

[mjwitte]

@Myoldmopar @JasonGlazer I think tankHeightForTesting needs to be sensitive to the Tank Shape type.

[Myoldmopar]

That makes all the sense. #dumb

I'll make that change shortly.

[JasonGlazer]

Also, the code seems to be assuming a horizontal cylinder but looks like it would run for a vertical or horizontal orientation.

[Myoldmopar]

I think 222ee92 should take care of this now. Unless I'm missing something from @JasonGlazer 's last comment.

[mjwitte]

@Myoldmopar Code changes look correct to me. I don't have time to test at the moment, but can tomorrow.

[JasonGlazer]

@Myoldmopar and @mjwitte the code change looks good to me too and the CI tests are clean.