Include fan heat when sizing zone cooling coils and adjust airloop coil inlet/outlet conditions #6753

rraustad · 2018-05-18T17:19:21Z

Pull request overview

Overview: Include fan heat when sizing zone cooling coils.
Description: Zone equipment that include use of a cooling coil have sized that equipment using only the zone load. This update includes design fan heat in the cooling coil sizing algorithms. For all coil types the design coil load now includes the zone load plus a term for design fan heat. For water coils, the additional fan heat increases the required water flow rate and the coil inlet air temperature (for blow-thru fans) or decreases the outlet air temperature (for draw-thru fans) used during sizing. Although system cooling coils, those cooling coils in air loops that reside directly on the main branch, have previously included fan heat, this update also adjusts the coil air inlet/outlet temperature (same as implemented with this update for zone coils). Heating coils are not affected by this change and do not currently include fan heat or an adjustment to coil entering or exiting air condition in the sizing algorithms.

Equipment modified by this change include:

Equipment not modified

AirTerminal:SingleDuct:ConstantVolume:FourPipeInduction (no local fan object)
AirTerminal:SingleDuct:ConstantVolume:FourPipeBeam (no local fan object)
AirTerminal:SingleDuct:ConstantVolume:CooledBeam (no local fan object)
AirTerminal:SingleDuct:ParallelPIU:Reheat (no fan type field, heating only)
AirTerminal:SingleDuct:SeriesPIU:Reheat (no fan type field, heating only)

Work Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:
- Defect: This pull request repairs a github defect issue. The github issue should be referenced in the PR description
- Refactoring: This pull request includes code changes that don't change the functionality of the program, just perform refactoring
- NewFeature: This pull request includes code to add a new feature to EnergyPlus
- Performance: This pull request includes code changes that are directed at improving the runtime performance of EnergyPlus
- DoNoPublish: This pull request includes changes that shouldn't be included in the changelog

Review Checklist

This will not be exhaustively relevant to every PR.

rraustad · 2018-05-18T19:59:48Z

@Myoldmopar these results concern me since this change should have shown diff's for the i386-Windows-7-VisualStudio-14 build. I'm seeing the same thing (intermittently) on the FSEC CI. Any ideas?

mjwitte · 2018-05-21T15:20:53Z

@rraustad I haven't trusted diffs on the Win platforms for a long time. I frequently see no diffs from Win when the other platforms show diffs. I don't think it's building the correct baseline branch, but I can't prove that. I focus on the diffs from Mac and Linux and only address failures on Win.

rraustad · 2018-05-22T17:42:18Z

There is a section in CI.rb that tests for a build folder and skips the regression tests if that folder exists. My guess is that the build folders on i386 Win are not getting completely deleted.

at line 337:

              if !File.directory?(regression_base.get_build_dir(compiler))
                $logger.info "Beginning regression baseline (#{regression_base.descriptive_string}) build for #{compiler} #{p.descriptive_string}"
                regression_base.do_build compiler, nil
                regression_base.do_test compiler, nil
              else
                $logger.info "Skipping already completed regression baseline (#{regression_base.descriptive_string}) build for #{compiler} #{p.descriptive_string}"
              end

Myoldmopar · 2018-05-23T15:04:14Z

You might be onto something big time @rraustad.... That code right there does a couple things:

Gets the build directory for a specific compiler. That's going to result in a path like <clone_folder>/build, where clone_folder has the platform and architecture and SHA or tag in it, so it should be unique across the dimensions we need it to be unique
If that build folder already exists, then presumably we have already built that unique configuration and we don't have to rebuild it; time saved! If it doesn't exist, we build that configuration so that we can do regressions.

I do know we have had trouble deleting some folders in the past because the operating system thought a process was still holding onto a random file deep in the build folder. If that's the case, then this code will fallthrough and the build folder will be there so the code won't rebuild. Then when regressions run, the base folder won't be there, so the regressions won't show up as failures. This could explain how @mjwitte doesn't see diffs on Windows when he expects to see them.

Unfortunately, @lefticus has tried really hard to delete the build folders using a variety of methods. If you recall, we used to have trouble with the CI machine hard drives filling up because the old builds wouldn't get deleted. I believe he exhausted his known options the last time we had to deal with this issue, but maybe there's something new we can try.

I'll add this to my list of things to look into, and in the meantime keep looking to the Linux and Mac boxes for diffs, and we'll rely on Windows for unit and integration test failures, and Windows-only build issues.

(How acceptable would it be to just disable regressions on Windows...? If we can rely on diffs being reported by Linux and Mac, it would drastically speed up the Windows CI runs to not have to build a wasted baseline.)

mjwitte · 2018-05-23T16:14:10Z

No regressions on Windows? Short-term, sure, but long-term should work to reliably restore them, even if we always build regardless of an existing build folder. But even then, would we still have trouble with possibly locked files?

rraustad · 2018-05-27T01:58:01Z

After some edits in the scripts, we are getting identical answers between i386 and Win64, as it should be.

Myoldmopar · 2018-05-27T02:17:25Z

Feel free to offer a pull request if you want and if you haven't already. Great work!

On Sat, May 26, 2018 at 20:58 Richard Raustad ***@***.***> wrote: After some edits in the scripts, we are getting identical answers between i386 and Win64, as it should be. [image: fsec_ci_results] <https://user-images.githubusercontent.com/5778156/40581820-ca08c2f4-612f-11e8-90c2-eadcfc7afe2c.jpg> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6753 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAz3oFQd3c2IqOyDcv8MX5d7UuRQKBX8ks5t2ggpgaJpZM4UFFHS> .

-- Edwin Lee, PhD Engineer, Commercial Buildings Research Staff National Renewable Energy Laboratory

rraustad · 2018-05-27T02:29:28Z

Well I may have simplified the answer. Our IT has been looking into how to reliably delete the build folders and the answer may be outside the scripts so a PR wouldn't be possible. I'll let you know what I find.

Myoldmopar · 2018-05-30T16:13:41Z

Thanks for letting me know anything you do find @rraustad; I'm excited to see the build folders get reliably deleted.

As for this feature, I was thinking I'd just comment on the NFP here? I didn't see a separate conversation, so my apologies if some of these have already been discussed.

First, the NFP is provided to the team over in the dev support repo, but that's private, so unless you have a reason to keep it private, please drop it into the design folder right here in this public repo, on this branch. Then the NFP/design can live and evolve alongside the code (and docs, idd, tests, etc.).
As for keeping a different variable for the fan index based on fan type, this is indeed because of the disjointed index nature of the fans, helping to ensure that developers are more cautious and it makes it more difficult to grab the wrong index. I think the idea is that as the older fan models are refactored, they will become a part of the vector and the IF blocks and multiple variables will fall away.
As for as the implementation you laid out, it looks reasonable to me.

rraustad · 2018-06-04T17:03:23Z

src/EnergyPlus/OutdoorAirUnit.cc

-                    OutAirUnit(OAUnitNum).EFanMaxAirVolFlow = HVACFan::fanObjs[OutAirUnit(OAUnitNum).SFan_Index]->designAirVolFlowRate;
-                    OutAirUnit(OAUnitNum).ExtFanAvailSchedPtr = HVACFan::fanObjs[OutAirUnit(OAUnitNum).SFan_Index]->availSchedIndex;
+                    OutAirUnit(OAUnitNum).EFanMaxAirVolFlow = HVACFan::fanObjs[OutAirUnit(OAUnitNum).ExtFan_Index]->designAirVolFlowRate;
+                    OutAirUnit(OAUnitNum).ExtFanAvailSchedPtr = HVACFan::fanObjs[OutAirUnit(OAUnitNum).ExtFan_Index]->availSchedIndex;


Fixed typo in exhaust fan.

…-Feature---Account-for-fan-heat-is-zone-cooling-coils

rraustad · 2018-06-08T14:53:30Z

Adding documentation to Engineering Reference. The fan heat calculations are in section Loop, Equipment Sizing and other Design Data, right after Fan Sizing is a new section for Design Fan Heat.

Then in the coil objects, a term for design fan heat is added to the design coil load calculation and the fan heat section is referenced in the equation variable description (i.e., see Section 10.7.3).

\item
  \(\dot{Q}_{fan,heat,des}\) : is the design fan heat (W) - see Section \ref{design-fan-heat}

rraustad · 2018-06-08T19:57:26Z

doc/engineering-reference/src/loop-equipment-sizing-and-other-design-data/component-sizing.tex

@@ -968,8 +1019,10 @@ \subsubsection{System Coils}\label{system-coils-5}

 \emph{CapModFac} = \emph{CurveValue}(CCapFTemp,\emph{T\(_{mix,wb}\)},\emph{T\(_{outside}\)})

+\emph{Q\(_{fan,heat,des}\)} = design fan heat (W) - see Section \ref{design-fan-heat}


How do I get the \dot{Q} inside the \emph{}. I tried a few different ways and nothing worked.

rraustad · 2018-06-08T20:00:14Z

doc/engineering-reference/src/loop-equipment-sizing-and-other-design-data/component-sizing.tex

-                                    \frac{\dot{m}_{air,des}\PB{48000 -H_{out}}}{TotCapTempModFac}  & otherwise
-                                  \end{array}
-                                \right.
+  \dot{Q}_{coil,des,total}   = \frac{\dot{m}_{air,des}\PB{H_{in}-H_{out}}}{TotCapTempModFac} + \dot{Q}_{fan,heat,des}


The Coil:Cooling:WaterToAirHeatPump:EquationFit model doesn't check for Hin>Hout, the variable speed model does. So I corrected the doc. I could have corrected the code but I never did like that test. If Hin<Hout then there should be 0 capacity.

rraustad · 2018-06-09T04:15:59Z

I don't see anything unexpected in the CI diff's. Coil sizes are a little larger and associated coil properties (e.g., water coil UA and DX coil SHR) are adjusted accordingly.

rraustad · 2018-06-09T04:20:02Z

@Myoldmopar I'll need some help with the warning. I didn't change that?

Myoldmopar · 2018-06-10T02:09:01Z

The full error message is several lines long, so the CI parser doesn't grab the whole thing. Here's what I see when I compile locally:

In file included from /6eplus/src/EnergyPlus/HVACVariableRefrigerantFlow.cc:64:0:
/6eplus/src/EnergyPlus/DataAirSystems.hh: In function ‘void EnergyPlus::HVACVariableRefrigerantFlow::SizeVRF(int)’:
/6eplus/src/EnergyPlus/DataAirSystems.hh:404:44: warning: unused variable ‘EnergyPlus::DataAirSystems::PrimaryAirSystem’ [-Wunused-variable]
     extern Array1D<DefinePrimaryAirSystem> PrimaryAirSystem;

This tells me that in the SizeVRF function, you now have a using statement for PrimaryAirSystem that isn't actually being used anymore. I took out the problematic line and it looks to be building fine without it just fine so I'll push the code back up now.

rraustad · 2018-06-11T15:33:11Z

I am looking at the results of water coil sizing. I was bothered about the first water coil I looked at where the reported coil capacity increased by only 1 W. The fan heat is getting added to the coil capacity calculation. for example file 5ZoneFanCoilDOASCool fan heat is on the order of 17 W. This additional load does translate directly to an increase in water flow rate of 6E-7 m3/s.

MaxColdWaterVolFlowDes = DesCoilLoad / (WaterCoilSizDeltaT * Cp * rho);
where 17 W / (6.67 * 4198 * 999.9 ) = 6E-7

- Component Sizing Information, ZoneHVAC:FourPipeFanCoil, SPACE1-1 FAN COIL, Design Size Maximum Cold Water Flow [m3/s], 9.66956E-005
- Component Sizing Information, Coil:Cooling:Water, SPACE1-1 COOLING COIL, Design Size Design Water Flow Rate [m3/s], 9.66956E-005
+ Component Sizing Information, ZoneHVAC:FourPipeFanCoil, SPACE1-1 FAN COIL, Design Size Maximum Cold Water Flow [m3/s], 9.73168E-005
+ Component Sizing Information, Coil:Cooling:Water, SPACE1-1 COOLING COIL, Design Size Design Water Flow Rate [m3/s], 9.73168E-005

However, this resulted in a reported coil capacity increase of 1 W and a UA decrease of 2 W/C and corresponding decrease in coil surface area.

! <Water Cooling Coil Capacity Information>,Component Type,Name,Nominal Total Capacity {W},Nominal Sensible Capacity {W},Nominal Latent Capacity {W},Nominal Sensible Heat Ratio, Nominal Coil UA Value {W/C}, Nominal Coil Surface Area {m2}
-Water Cooling Coil Capacity Information,Coil:Cooling:Water,SPACE1-1 COOLING COIL,3592.51,2570.41,1022.11,0.72,399.02,4.05
+Water Cooling Coil Capacity Information,Coil:Cooling:Water,SPACE1-1 COOLING COIL,3593.64,2570.26,1023.38,0.72,397.67,4.03

So something is wrong here.
Note that the design size inlet air temperature did not change and if we are going to include fan heat, for either blow-thru or draw-thru, then I think the inlet temp needs adjusting. @mjwitte @EnergyArchmage @Myoldmopar what do you think about that?

Component Sizing Information, Coil:Cooling:Water, SPACE1-1 COOLING COIL, Design Size Design Inlet Air Temperature [C], 23.99567

This is a fan coil unit.

} else if (SizingType == CoolingWaterDesAirInletTempSizing) {
    if (TermUnitIU) {
        AutosizeDes = FinalZoneSizing(CurZoneEqNum).ZoneTempAtCoolPeak;
    } else if (ZoneEqFanCoil) {
        if (FinalZoneSizing(CurZoneEqNum).DesCoolMassFlow > 0.0) {
            OutAirFrac = min(StdRhoAir * ZoneEqSizing(CurZoneEqNum).OAVolFlow / FinalZoneSizing(CurZoneEqNum).DesCoolMassFlow, 1.0);
        } else {
            OutAirFrac = 0.0;
        }
        AutosizeDes = OutAirFrac * FinalZoneSizing(CurZoneEqNum).OutTempAtCoolPeak +
                                  (1.0 - OutAirFrac) * FinalZoneSizing(CurZoneEqNum).ZoneTempAtCoolPeak;
    } else {
        AutosizeDes = FinalZoneSizing(CurZoneEqNum).DesCoolCoilInTemp;
    }

…-Feature---Account-for-fan-heat-is-zone-cooling-coils

rraustad · 2018-08-28T17:22:31Z

I've reviewed many of the diff's and they all appear to reflect fan heat added to capacity and inlet or outlet condition with slight increases in water cooling coil water flow rate. So this appears ready. Just so you know I revised this so that fan heat increases inlet air temp for blow-thru and decreases outlet air temp for draw-thru (I originally put the fan heat at the coil inlet which was wrong for draw-thru configurations). I was scared of that at first and then thought that we do that all the time with the mixed air SPM so why no go ahead and do it for sizing.

…-Feature---Account-for-fan-heat-is-zone-cooling-coils

rraustad · 2018-09-11T16:01:19Z

The example file results I have reviewed so far show an increase in capacity and a change in inlet or outlet air conditions based on blow- or draw-thru fan configuration. This is looking pretty good so far.

rraustad · 2018-09-11T16:54:00Z

Things still look good but noticed a few things a reviewer would need to understand:

main air loop coils already account for fan heat and the only thing changing is the correction to coil inlet or outlet air condition.
the change in inlet condition is actually causing a reduction in cooling coil capacity in main air loop DX coils using blow-thru because the WB temp is higher and the CapFT is also higher leading to a smaller capacity (Cap = load / CapFT).
some diff's show only a change in sensible capacity. These are coils where total capacity has not changed (because fan heat was already accounted for) and the change in inlet or outlet air temperature leads to a change in calculated sensible capacity.

…e---Account-for-fan-heat-is-zone-cooling-coils

mjwitte · 2018-09-13T19:10:15Z

@rraustad Have you reviewed the err diffs? Some of these may need to be addressed.
5ZoneWarmestVFD

5ZoneWarmestVFD_FCMAuto

CoolingTower_FluidBypass and similar warnings for CoolingTower_TwoSpeed_MultiCell, CoolingTower_VariableSpeed_MultiCell, EMSDemandManager_LargeOffice, EMSReplaceTraditionalManagers_LargeOffice.

On the good new side, coil sizing warnings are now gone for RefBldgSecondarySchoolNew2004_Chicago and RefBldgSecondarySchoolNew2004_Chicago - woohoo!

RefBldgSmallHotelNew2004_Chicago

_SmallOffice_Dulles

And strange messages for _5ZoneAirCooled_annual under Failure here:

Processing (Diffs) : _5ZoneAirCooled_annual
Traceback (most recent call last):
File "/Users/kbenne/ci_runs/EnergyPlus-3958623a89-x86_64-clang/regressions/Testing/RegressionSuite/Scripts/RunComparison.py", line 78, in 
runner.process_diffs_for_one_case(entry, base_dir, mod_dir, mod_dir)
File "/Users/kbenne/ci_runs/EnergyPlus-3958623a89-x86_64-clang/regressions/Testing/RegressionSuite/Scripts/runtests.py", line 445, in process_diffs_for_one_case
path_to_tablediff_log)))
File "/Users/kbenne/ci_runs/EnergyPlus-3958623a89-x86_64-clang/regressions/Testing/RegressionSuite/Scripts/TableDiff.py", line 434, in table_diff
hdict2soup(abs_diff_soup, uheading1, count_of_tables, abs_diff_dict, h_thresh_dict, horder1)
File "/Users/kbenne/ci_runs/EnergyPlus-3958623a89-x86_64-clang/regressions/Testing/RegressionSuite/Scripts/TableDiff.py", line 205, in hdict2soup
tdtag.append((hdict[h][i]).encode('utf-8'))
AttributeError: 'tuple' object has no attribute 'encode'

rraustad · 2018-09-13T19:33:04Z

Those warnings are all a result of changing the inlet or outlet temperature based on fan heat. I knew the water coil would be a thorn in my side when deciding to adjust the outlet air temp for draw-thru configurations. But since we do that during the simulation with the mixed air temp SPM I thought the problems would be minimal and went ahead and adjusted coil air properties accordingly to fan location. I also think that the warning for bypass factor calculation failure points to some other issue since that warning is only printed if bypass factor > 0.5 (highly unlikely). Given the temperatures in the messages (i.e, inlet water temp vs inlet and outlet air temp) the bypass factor should not be that large so something else is going on (I think ADP is calculated much colder than the inlet water temp). I probably don't have time to correct that in this branch but will start investigating the correction. I also have another check in since I just found that water coils are counting fan heat twice when reporting outlet air temperature (e.g., water coil calls CoolingWaterDesAirInletTempSizing and CoolingWaterDesAirOutletTempSizing where fan heat is accounted for then passes those data over to CoolingCapacitySizing in RequestSizing. This would double count fan heat for water coils with draw-thru fans. I'm trying to figure out the best way around this. Maybe it's a simple matter of only accounting for fan heat when capacity is calculated, not sure at this point.

if (DataDesOutletAirTemp > 0.0) {
    CoilOutTemp = DataDesOutletAirTemp;
} else {
    CoilOutTemp = FinalSysSizing(CurSysNum).CoolSupTemp;
}

rraustad · 2018-09-14T00:25:06Z

Perfect example of the bypass factor warning that existed before this change and is exacerbated when SAT is lowered. Example file: RefBldgLargeHotelNew2004_Chicago

I looked through all err files and don't see anything that should hold this up.

    ************* Beginning Plant Sizing Calculations
    ** Warning ** In calculating the design coil UA for Coil:Cooling:Water FLR_3_DOAS_COOLC
    **   ~~~   ** no apparatus dew-point can be found for the initial entering and leaving conditions;
-   **   ~~~   ** the coil outlet design conditions will be changed to correct the problem.
    **   ~~~   ** The initial design conditions are: Tair,in = 30.6608
    **   ~~~   **                                    Wair,in = 1.878287E-002
    **   ~~~   **                                    Twater,in = 6.6700
-   **   ~~~   **                                    Tair,out = 12.8200
+   **   ~~~   **                                    Tair,out = 11.9255
    **   ~~~   **                                    Wair,out = 8.489894E-003
-   **   ~~~   ** The revised design conditions are: Tair,out = 12.8197
-   **   ~~~   **                                    Wair,out = 8.490011E-003
    ** Warning ** In calculating the design coil UA for Coil:Cooling:Water FLR_6_DOAS_COOLC
    **   ~~~   ** no apparatus dew-point can be found for the initial entering and leaving conditions;
-   **   ~~~   ** the coil outlet design conditions will be changed to correct the problem.
    **   ~~~   ** The initial design conditions are: Tair,in = 30.2604
    **   ~~~   **                                    Wair,in = 1.878286E-002
    **   ~~~   **                                    Twater,in = 6.6700
-   **   ~~~   **                                    Tair,out = 12.8200
+   **   ~~~   **                                    Tair,out = 11.9255
    **   ~~~   **                                    Wair,out = 8.489894E-003
-   **   ~~~   ** The revised design conditions are: Tair,out = 12.8197
-   **   ~~~   **                                    Wair,out = 8.490011E-003

mjwitte · 2018-09-14T11:07:17Z

There are doc build errors here. For the delimiter issue, it may be similar to this.

mjwitte · 2018-09-14T11:50:57Z

I'm going to post a followup issue then to clean up the example files and get rid of the coil sizing warnings.
Since you need to fix the doc errors here, please fix this warning message: "Cooling Coil has leaving air temperature > entering water temperature." > should be <.

mjwitte · 2018-09-14T12:44:09Z

@Myoldmopar Can you help diagnose why tablediff is failing on _5ZoneAirCooled_annual? Look here, expand the regression test failures, and search for "traceback".

Myoldmopar · 2018-09-14T13:20:30Z

That code is failing here. It is in a section of TableDiff where the diff tables are being written. Specifically, it's trying to write a value to a cell inside a diff table. That code has an IF block, where if the header of this is "DummyPlaceholder" or "Subcategory", it just writes the value out to the table. If it isn't one of those values, it assumes the value is a list, and unpacks two values from it and only writes the first one. It's failing because it seems like this header is Dummy or Subcategory, yet it has a list instead of a single value.

I looked over the code and didn't see anything obvious in the tabular reports. Is there anything that you see that could be causing a header change, or structural output value change? If there isn't, then maybe re-run CI to make sure that persists, and then if it does I'll take a look locally.

mjwitte · 2018-09-14T14:17:02Z

The order of columns is changing in one of the tables. Would that be the culprit? Component Sizing Summary, Coil:Cooling:Water, the Design Size Design Inlet Air Humidity Ratio is earlier now than before.

…-Feature---Account-for-fan-heat-is-zone-cooling-coils

mjwitte

Some more questions/comments.

src/EnergyPlus/FanCoilUnits.cc

src/EnergyPlus/HVACMultiSpeedHeatPump.cc

mjwitte · 2018-09-14T16:06:48Z

src/EnergyPlus/VariableSpeedCoils.cc

+                                                                RoutineName,                                // Routine name
+                                                                CurrentModuleObject,                        // Object Type
+                                                                VarSpeedCoil(DXCoilNum).Name,               // Object Name
+                                                                cAlphaFields(AlfaFieldIncre));              // Field Name


@Myoldmopar So, seems like Visual Studio is interpreting the clang format differently from linux?

mjwitte · 2018-09-14T16:09:29Z

src/EnergyPlus/VariableSpeedCoils.cc

+                    // design fan heat will be added to coil load
+                    Real64 FanCoolLoad = DataAirSystems::calcFanDesignHeatGain(DataFanEnumType, DataFanIndex, VolFlowRate);
+                    // inlet/outlet temp is adjusted after enthalpy is calculcated so fan heat is not double counted
+                    Real64 CpAir = PsyCpAirFnWTdb(MixHumRat, MixTemp);


You've mentioned this before, I think, but why isn't MixEnth adjusted here?

Given the test below at line 4082 for MixEnth > SupEnth it looks like MixEnth or SupEnth should have been updated here. However, the comment "The mixed air temp for zone equipment without an OA mixer is 0" implies it doesn't matter because MixEnth will always be greater than SupEnth (unless MixEnth=0 and then if IF at line 4082 would still work as intended).

I wasn't asking about this particular coil type, but I think this is the general method elsewhere as well, no? Leave the enthalpies, add the load, but adjust the entering or leaving conditions. Just seems it would be cleaner to adjust the entering or leaving conditions first, then the enthalpies would already include the extra fan heat.

mjwitte · 2018-09-14T16:12:30Z

src/EnergyPlus/WaterCoils.cc

@@ -2143,6 +2143,23 @@ namespace WaterCoils {
                    ShowContinueError("The autosize value for max air volume flow rate is zero");
                }



It doesn't hurt anything other than it causes reordering in some of the output.

src/EnergyPlus/WaterToAirHeatPumpSimple.cc

src/EnergyPlus/ReportSizingManager.cc

mjwitte · 2018-09-14T18:05:19Z

Ran a few annual simulations just to see what the overall diffs are. Surprising:

5ZoneAirCooled, PackagedTerminalAirConditioner - Some coil sizing diffs, as expected, <1% annual energy, no difference in setpoint not met or not comfortable hours.

FanCoilAutoSizen, PackagedTerminalHeatPump - Some coil sizing diffs, as expected, <1% annual energy, small diffs in setpoint not met or not comfortable hours.

RefBldgHospitalNew2004_Chicago - no diffs at all - is that expected? All airloops with detailed chilled water coil.

rraustad · 2018-09-14T18:10:59Z

RefBldgHospitalNew2004_Chicago - air loops already accounted for the fan heat so the diff's would be in the html reporting of entering/leaving air temp.

mjwitte

At this point, just waiting for linux ci to finish up to check if the doc build errors are gone and reconfirm performance change (last round showed a 1.5% improvement, not sure how that's possible).

mjwitte · 2018-09-14T18:21:43Z

Oh - there it is - only the cooling coi leaving wet bulbs and enthalpies. Seems like something more should change, but not pressing this.

mjwitte · 2018-09-14T18:57:56Z

Engineering ref builds locally and looks OK. Gort seems rather far behind, so merging this so we can get going on others that will likely have conflicts after this drops. If there are any doc build problems, we'll fix them later.

Apply example method for adding fan heat in sizing PTUnit

6f32653

rraustad changed the title ~~Apply example method for adding fan heat in sizing PTUnit~~ New Feature - Include fan heat when sizing zone cooling coils May 18, 2018

Correct test for 0 based fan index

a2e2e09

rraustad added 2 commits May 18, 2018 21:36

Move fan heat to before CAPFT use

949ac99

Change initialization for better protection

39b0aa3

rraustad added the NewFeature Includes code to add a new feature to EnergyPlus label May 25, 2018

rraustad added 2 commits May 30, 2018 16:56

Modify multiple zone equipment models for fan heat

5508995

Add window AC and outdoor air unit for fan heat for zone coils.

db98d7d

rraustad commented Jun 4, 2018

View reviewed changes

rraustad added 3 commits June 7, 2018 14:11

Final code changes. Add unit testing.

cd2dabf

Add new unit test.

259273d

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into New…

1bb2488

…-Feature---Account-for-fan-heat-is-zone-cooling-coils

Add Eng. REf. updates. Include other coil/system types to be thorough.

7d1a264

rraustad commented Jun 8, 2018

View reviewed changes

Removed unused using statement; CI should be happier now

55f9974

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into New…

52d2325

…-Feature---Account-for-fan-heat-is-zone-cooling-coils

rraustad mentioned this pull request Aug 31, 2018

Refactor AirloopHVAC:UnitarySystem #6799

Merged

35 tasks

rraustad added 2 commits September 10, 2018 19:19

Add main air loop water coil air conditions due to fan heat

f1a539b

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into New…

3958623

…-Feature---Account-for-fan-heat-is-zone-cooling-coils

Merge remote-tracking branch 'remotes/origin/develop' into New-Featur…

f1b6227

…e---Account-for-fan-heat-is-zone-cooling-coils

Correct double counting fan heat in water coil outlet temp

e5b8c26

mjwitte mentioned this pull request Sep 14, 2018

Clean up coil sizing warnings in example files #6962

Open

7 tasks

rraustad added 2 commits September 14, 2018 10:29

Correct doc build warnings?

6152e81

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into New…

f2df9ec

…-Feature---Account-for-fan-heat-is-zone-cooling-coils

mjwitte changed the title ~~New Feature - Include fan heat when sizing zone cooling coils~~ Include fan heat when sizing zone cooling coils and adjust airloop coil inlet/outlet conditions Sep 14, 2018

mjwitte reviewed Sep 14, 2018

View reviewed changes

mjwitte approved these changes Sep 14, 2018

View reviewed changes

mjwitte merged commit 429d666 into develop Sep 14, 2018

mjwitte deleted the New-Feature---Account-for-fan-heat-is-zone-cooling-coils branch September 14, 2018 18:58

mjwitte mentioned this pull request May 8, 2020

Eliminate double counting of fan heat for water cooling coils #7886

Merged

20 tasks

		@@ -968,8 +1019,10 @@ \subsubsection{System Coils}\label{system-coils-5}

		\emph{CapModFac} = \emph{CurveValue}(CCapFTemp,\emph{T\(_{mix,wb}\)},\emph{T\(_{outside}\)})

		\emph{Q\(_{fan,heat,des}\)} = design fan heat (W) - see Section \ref{design-fan-heat}

		@@ -2143,6 +2143,23 @@ namespace WaterCoils {
		ShowContinueError("The autosize value for max air volume flow rate is zero");
		}

Navigation Menu

Include fan heat when sizing zone cooling coils and adjust airloop coil inlet/outlet conditions #6753

Include fan heat when sizing zone cooling coils and adjust airloop coil inlet/outlet conditions #6753

Conversation

rraustad commented May 18, 2018 • edited by mjwitte

Pull request overview

Equipment modified by this change include:

Equipment not modified

Work Checklist

Review Checklist

rraustad commented May 18, 2018

mjwitte commented May 21, 2018

rraustad commented May 22, 2018

Myoldmopar commented May 23, 2018

mjwitte commented May 23, 2018

rraustad commented May 27, 2018

Myoldmopar commented May 27, 2018 via email

rraustad commented May 27, 2018

Myoldmopar commented May 30, 2018

Choose a reason for hiding this comment

rraustad commented Jun 8, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rraustad commented Jun 9, 2018

rraustad commented Jun 9, 2018 • edited

Myoldmopar commented Jun 10, 2018

rraustad commented Jun 11, 2018

rraustad commented Aug 28, 2018

rraustad commented Sep 11, 2018

rraustad commented Sep 11, 2018

mjwitte commented Sep 13, 2018

rraustad commented Sep 13, 2018

rraustad commented Sep 14, 2018 • edited

mjwitte commented Sep 14, 2018

mjwitte commented Sep 14, 2018

mjwitte commented Sep 14, 2018

Myoldmopar commented Sep 14, 2018

mjwitte commented Sep 14, 2018

mjwitte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjwitte commented Sep 14, 2018

rraustad commented Sep 14, 2018

mjwitte left a comment

Choose a reason for hiding this comment

mjwitte commented Sep 14, 2018

mjwitte commented Sep 14, 2018

rraustad commented May 18, 2018 •

edited by mjwitte

rraustad commented Jun 8, 2018 •

edited

rraustad commented Jun 9, 2018 •

edited

rraustad commented Sep 14, 2018 •

edited