Fix Zone Contaminant Source or Sink CO2 Gain Volume Flow Rate output

[mjwitte]

Pull request overview

• Fixes Zone Contaminant Source or Sink CO2 Gain Volume Flow Rate does not reset to zero each timestep #7905
• Zone Contaminant Source or Sink CO2 Gain Volume Flow Rate output was not getting reset to zero for each timestep, so the reported value kept accumulating over the course of the simulation.

The #7905 defect file should report exactly the same values in columns B and C:
CO2PEOPLE:Contaminant Source or Sink CO2 Gain Volume Flow Rate m3/s
CLASSROOM:Zone Contaminant Source or Sink CO2 Gain Volume Flow Rate m3/s

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  No diffs expected, because Zone Contaminant Source or Sink CO2 Gain Volume Flow Rate is not used in any of the testfiles.
  Added outputs to HeatPumpIAQP_GenericContamControl.idf
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[mjwitte]

This was forgotten here. Note that not all variables in ZnRpt are set to zero here. Just the ones that are accumulated with += in this function.

[mjwitte]

Note the increase in unit test coverage.

Develop:                         Line Coverage         Function Coverage
InternalHeatGains.cc |   |   | 55.7 % | 2089 / 3751 | 76.5 % | 26 / 34
This branch:
InternalHeatGains.cc |   |   | 72.8 % | 2733 / 3752 | 76.5 % | 26 / 34

 

 

[rraustad]

No example files use this report variable? Should add it to one or more?

[rraustad]

Looked over the function where this change was made. This change looks like it includes everything.

[rraustad]

CO2 report looks correct now.

[rraustad]

Unit tests run to completion locally.

[rraustad]

The 1 unit test failure appears unrelated and this specific failure is occurring more often.

[rraustad]

@mjwitte this all looks good and is ready to merge. What do you think about adding the report to one of the example files?

[rraustad]

Why isn't this showing that little error with no line feed after the last bracket?

[rraustad]

Oh, because it's not showing line 1006.

[mjwitte]

@rraustad Added output variables to one test file and corrected the docs for some of the output variables.

[rraustad]

• Reports added to example file
• Review doc changes, built IO Ref and reviewed changes
• CI reports show expected results