Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AirLoopHVACUnitarySystem set Method During XXX Operation #4873

Merged
merged 44 commits into from
Aug 1, 2023
Merged

AirLoopHVACUnitarySystem set Method During XXX Operation #4873

merged 44 commits into from
Aug 1, 2023

Commits on May 2, 2023

  1. Stub failing test for methods not set.

    @joseph-robertson
    joseph-robertson committed May 2, 2023
    Configuration menu
    Copy the full SHA
    05a66a8 View commit details
    Browse the repository at this point in the history

  2. Stub updates to autosize methods.

    @joseph-robertson
    joseph-robertson committed May 2, 2023
    Configuration menu
    Copy the full SHA
    650f4a0 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Try returnDefault is false in getString.

    @joseph-robertson
    joseph-robertson committed May 3, 2023
    Configuration menu
    Copy the full SHA
    08d6eef View commit details
    Browse the repository at this point in the history

  2. Follow fanPlacement which also has no default.

    @joseph-robertson
    joseph-robertson committed May 3, 2023
    Configuration menu
    Copy the full SHA
    4d15331 View commit details
    Browse the repository at this point in the history

  3. Update remaining supply air flow setters and methods.

    @joseph-robertson
    joseph-robertson committed May 3, 2023
    Configuration menu
    Copy the full SHA
    4c89e2c View commit details
    Browse the repository at this point in the history

  4. Set method for no heating or cooling required fields.

    @joseph-robertson
    joseph-robertson committed May 3, 2023
    Configuration menu
    Copy the full SHA
    31faca7 View commit details
    Browse the repository at this point in the history

  5. Add tests for no heating or cooling required fields.

    @joseph-robertson
    joseph-robertson committed May 3, 2023
    Configuration menu
    Copy the full SHA
    ed6c57e View commit details
    Browse the repository at this point in the history

  6. Formatting.

    @joseph-robertson
    joseph-robertson committed May 3, 2023
    Configuration menu
    Copy the full SHA
    898355e View commit details
    Browse the repository at this point in the history

  7. Fix typo in test method.

    @joseph-robertson
    joseph-robertson committed May 3, 2023
    Configuration menu
    Copy the full SHA
    373ef28 View commit details
    Browse the repository at this point in the history

  8. Improve comments.

    @joseph-robertson
    joseph-robertson committed May 3, 2023
    Configuration menu
    Copy the full SHA
    04d7fc8 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Merge branch 'develop' into airloop-hvac-unitary-sys-opmethod

    @joseph-robertson
    joseph-robertson committed May 24, 2023
    Configuration menu
    Copy the full SHA
    1319725 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Stub failing test for methods not set.

    @joseph-robertson @jmarrec
    joseph-robertson authored and jmarrec committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    e2ce997 View commit details
    Browse the repository at this point in the history

  2. Stub updates to autosize methods.

    @joseph-robertson @jmarrec
    joseph-robertson authored and jmarrec committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    a83e781 View commit details
    Browse the repository at this point in the history

  3. Try returnDefault is false in getString.

    @joseph-robertson @jmarrec
    joseph-robertson authored and jmarrec committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    af243a0 View commit details
    Browse the repository at this point in the history

  4. Follow fanPlacement which also has no default.

    @joseph-robertson @jmarrec
    joseph-robertson authored and jmarrec committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    7dc6f32 View commit details
    Browse the repository at this point in the history

  5. Update remaining supply air flow setters and methods.

    @joseph-robertson @jmarrec
    joseph-robertson authored and jmarrec committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    0736feb View commit details
    Browse the repository at this point in the history

  6. Set method for no heating or cooling required fields.

    @joseph-robertson @jmarrec
    joseph-robertson authored and jmarrec committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    8261fe2 View commit details
    Browse the repository at this point in the history

  7. Add tests for no heating or cooling required fields.

    @joseph-robertson @jmarrec
    joseph-robertson authored and jmarrec committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    8efa6fb View commit details
    Browse the repository at this point in the history

  8. Formatting.

    @joseph-robertson @jmarrec
    joseph-robertson authored and jmarrec committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    44e25bf View commit details
    Browse the repository at this point in the history

  9. Fix typo in test method.

    @joseph-robertson @jmarrec
    joseph-robertson authored and jmarrec committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    f4eccd3 View commit details
    Browse the repository at this point in the history

  10. Improve comments.

    @joseph-robertson @jmarrec
    joseph-robertson authored and jmarrec committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    0401167 View commit details
    Browse the repository at this point in the history

  11. Cleanup the DuringCooling API. One break, the return of supplyAirFlow… 

    …RateMethodDuringCooling, which can be avoided (keep returning optional even if always initialized)
    @jmarrec
    jmarrec committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    9405db6 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Merge branch 'airloop-hvac-unitary-sys-opmethod' of github.com:NREL/O… 

    …penStudio into airloop-hvac-unitary-sys-opmethod
    @joseph-robertson
    joseph-robertson committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    c48189f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into airloop-hvac-unitary-sys-opmethod

    @joseph-robertson
    joseph-robertson committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    56a48d1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'airloop-hvac-unitary-sys-opmethod' into airloop-hvac-un… 

    …itary-sys-opmethod2
    @joseph-robertson
    joseph-robertson committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    5d93c8d View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Merge branch 'develop' into airloop-hvac-unitary-sys-opmethod

    @joseph-robertson
    joseph-robertson committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    880f7f1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'airloop-hvac-unitary-sys-opmethod' into airloop-hvac-un… 

    …itary-sys-opmethod2
    @joseph-robertson
    joseph-robertson committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    3728488 View commit details
    Browse the repository at this point in the history

  3. Add None default to idd.

    @joseph-robertson
    joseph-robertson committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    08858b4 View commit details
    Browse the repository at this point in the history

  4. Simplify method getter after introducing None default.

    @joseph-robertson
    joseph-robertson committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    fa7543a View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Merge pull request #4927 from NREL/airloop-hvac-unitary-sys-opmethod3 

    AirLoopHVACUnitarySystem set Method During XXX Operation - option, 2
    @jmarrec
    jmarrec committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    af26872 View commit details
    Browse the repository at this point in the history

  2. Add None default for HeatingOperation.

    @joseph-robertson
    joseph-robertson committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    d3d1f3d View commit details
    Browse the repository at this point in the history

  3. Updates for new os_deprecated method args.

    @joseph-robertson
    joseph-robertson committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    b54af03 View commit details
    Browse the repository at this point in the history

  4. Update ft for heating.

    @joseph-robertson
    joseph-robertson committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    dd0bd1a View commit details
    Browse the repository at this point in the history

  5. Update all heating methods.

    @joseph-robertson
    joseph-robertson committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    01ee57b View commit details
    Browse the repository at this point in the history

  6. Formatting.

    @joseph-robertson
    joseph-robertson committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    da09bd9 View commit details
    Browse the repository at this point in the history

  7. Clean up minor typos.

    @joseph-robertson
    joseph-robertson committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    79b6ca3 View commit details
    Browse the repository at this point in the history

  8. More case typos.

    @joseph-robertson
    joseph-robertson committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    57d142d View commit details
    Browse the repository at this point in the history

  9. Update model tests.

    @joseph-robertson
    joseph-robertson committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    fd3d025 View commit details
    Browse the repository at this point in the history

  10. More case typos.

    @joseph-robertson
    joseph-robertson committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    1413329 View commit details
    Browse the repository at this point in the history

  11. Stub deprecated_at_msg in cpp.

    @joseph-robertson
    joseph-robertson committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    2cef40d View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Update deprecated messages.

    @joseph-robertson
    joseph-robertson committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    df44eab View commit details
    Browse the repository at this point in the history

  2. Include deprecatedhelpers hpp.

    @joseph-robertson
    joseph-robertson committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    36a9a7d View commit details
    Browse the repository at this point in the history

  3. Merge pull request #4905 from NREL/airloop-hvac-unitary-sys-opmethod2 

    AirLoopHVACUnitarySystem set Method During XXX Operation - option
    @joseph-robertson
    joseph-robertson committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    b053f33 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Update release notes md file with notes on api break, etc.

    @joseph-robertson
    joseph-robertson committed Aug 1, 2023
    1 Configuration menu
    Copy the full SHA
    52b5d43 View commit details
    Browse the repository at this point in the history