-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4824 - Use a unique_path in create_temporary_directory to avoid collision #4903
Conversation
CI Results for 97e9c03:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Might be worth for @shorowit to test one of the installers.
Looks like @joseph-robertson is testing this; I'll leave it to him. |
Tested the installer here: NREL/resstock#1088. (Pointing to The "integration-tests" job passed, so IMO this PR is ready to go. |
…ror D:\git\OpenStudio\src\utilities\core\FilesystemHelpers.cpp(150): warning C4018: '<': signed/unsigned mismatch
Pull request overview
Pull Request Author
src/model/test
)src/energyplus/Test
)src/osversion/VersionTranslator.cpp
)Labels:
IDDChange
APIChange
Pull Request - Ready for CI
so that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.