Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better logic on simple plant builder to always build by iterating thr… #100

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

grantbuster
Copy link
Member

…ough resource gids within sc points and only build if not shared

…ough resource gids within sc points and only build if not shared
@codecov-io
Copy link

codecov-io commented Mar 24, 2021

Codecov Report

Merging #100 (22971fd) into main (eae45b0) will decrease coverage by 0.04%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
- Coverage   80.05%   80.00%   -0.05%     
==========================================
  Files          84       84              
  Lines        8602     8602              
==========================================
- Hits         6886     6882       -4     
- Misses       1716     1720       +4     
Flag Coverage Δ
unittests 80.00% <88.88%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
reVX/plexos/base.py 84.15% <25.00%> (-1.49%) ⬇️
reVX/plexos/simple_plant_builder.py 81.81% <100.00%> (-0.51%) ⬇️
reVX/handlers/database.py 0.00% <0.00%> (ø)
reVX/plexos/plexos_plants.py 68.76% <0.00%> (+0.07%) ⬆️
reVX/rpm/rpm_clusters.py 80.51% <0.00%> (+0.08%) ⬆️

Copy link
Collaborator

@MRossol MRossol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good on the surface

@grantbuster grantbuster merged commit 0a6e280 into main Mar 24, 2021
github-actions bot pushed a commit that referenced this pull request Mar 24, 2021
better logic on simple plant builder to always build by iterating thr…
@grantbuster grantbuster deleted the gb/plant_builder_debug branch March 24, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants