Fix DC degradation check should be lt instead of gt zero #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
janinefreeman
approved these changes
Mar 2, 2022
tyneises
added a commit
that referenced
this pull request
Mar 10, 2022
* Levelized label changes (#770) * Revise labels of "levelized" variables Also: * Remove parentheses from labels "LCOE Levelized cost of energy nominal" instead of "LCOE Levelized cost of energy (nominal)" because parentheses are used to indicate units. * Change WACC and LTE labels to follow convention of levelized variables. * Fix cashloan LCOE labels Fix NPV and IRR labels * Fix DC degradation check should be lt instead of gt zero (#772) * Improve error messages for wfcheck (#773) * Improve error messages for wfcheck * fix mm-dd-hh * first test upload artifacts steps ssc * use upload artifacts path format, add ls checks for paths * fixes for PySAM (#775) * Add subcooled outlet option to DSG LF IPH model (#776) * add dsg lf subcooled outlet target add ui callback to calc saturation temp * update ssc cmake * add boolean and unique input for subcooled output * add cmake flag for shared dylib * remove path test steps Co-authored-by: Paul Gilman <cpaulgilman@gmail.com> Co-authored-by: Brian Mirletz <brian.mirletz@nrel.gov> Co-authored-by: Darice L Guittet <dguittet@nrel.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes with NREL/SAM#958
Fixes NREL/SAM#957
File for testing:
degradation-inputs-test.zip