Record associate scan numbers in the config file #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofang
changed the title
leofang
commented
Feb 16, 2020
Comment on lines
+1403
to
+1404
| if self._extra_scans_dialog is not None: | ||
| self._extra_scans_dialog.close() |
There was a problem hiding this comment.
This is to fix a bug that the assoc scan window is not closed, thus preventing the whole program from being shutdown, when the main window is closed.
|
@mrakitin This PR could give you a taste what's needed to add new parameter to the main window. This example is a bit simplified, though, because the backend does not need this info and we don't need to add a new button to the main window, otherwise it'd be more complex. |
|
Merge at will. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #80.
This PR addresses the issue that the associate scan numbers are not recorded during GUI shutdown.
The accompanying PR for the backend is NSLS-II/ptycho#48.