Skip to content

Make TwoButtonShutter configurable.#100

Merged
Dan Allan (danielballan) merged 2 commits into
NSLS2:masterfrom
danielballan:configurable-TwoButtonShutter
Aug 27, 2020
Merged

Make TwoButtonShutter configurable.#100
Dan Allan (danielballan) merged 2 commits into
NSLS2:masterfrom
danielballan:configurable-TwoButtonShutter

Conversation

@danielballan
Copy link
Copy Markdown
Contributor

FXI needs more retries. Sure wish we could get this fixed in the IOC!

@codecov-commenter
Copy link
Copy Markdown

Codecov Comments Bot (codecov-commenter) commented Aug 24, 2020

Codecov Report

Merging #100 into master will increase coverage by 0.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   56.61%   57.17%   +0.56%     
==========================================
  Files          13       13              
  Lines         892      892              
==========================================
+ Hits          505      510       +5     
+ Misses        387      382       -5     
Impacted Files Coverage Δ
nslsii/_version.py 44.80% <0.00%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18c0632...4700a63. Read the comment docs.

@danielballan
Copy link
Copy Markdown
Contributor Author

One build had a random failure in the kafka publisher test, unrelated to this PR.

@danielballan Dan Allan (danielballan) merged commit 771d8a0 into NSLS2:master Aug 27, 2020
@danielballan Dan Allan (danielballan) deleted the configurable-TwoButtonShutter branch August 27, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants