Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(upon receiving) an ACK #101

Closed
larseggert opened this issue Aug 31, 2021 · 3 comments · Fixed by #103 or #110
Closed

(upon receiving) an ACK #101

larseggert opened this issue Aug 31, 2021 · 3 comments · Fixed by #103 or #110
Assignees

Comments

@larseggert
Copy link
Member

@larseggert larseggert commented Aug 31, 2021

Markku Kojo said:

In many occassions:

"(upon receiving) an ACK" -> "(upon receiving) a new ACK"

@larseggert
Copy link
Member Author

@larseggert larseggert commented Aug 31, 2021

Markku, #103 only fixes the one spot where the text said "Upon receiving an ACK". There are *many more places where we use "an ACK" - which of those do you think need to be changed?

@larseggert larseggert self-assigned this Aug 31, 2021
@markkukojo
Copy link
Collaborator

@markkukojo markkukojo commented Sep 15, 2021

I didn't pass through all occurrences because this was a generic comment to be precise. So, throughout the document any occurrence of "an/every/each ACK" that is intended to refer only to an ACK that cumulatively acknowledges new data would be good to indicate exactly (to not leave any doubt that the actions must not be taken on arriving dupAcks or window updates).

@larseggert
Copy link
Member Author

@larseggert larseggert commented Sep 16, 2021

Please take a look at #110. I think I found all the places now, but maybe there are some where the old phrasing was OK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants