Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sec 5.9 #98

Closed
larseggert opened this issue Aug 31, 2021 · 6 comments · Fixed by #116
Closed

Sec 5.9 #98

larseggert opened this issue Aug 31, 2021 · 6 comments · Fixed by #116
Assignees

Comments

@larseggert
Copy link
Member

@larseggert larseggert commented Aug 31, 2021

Markku Kojo said:

Sec 5.9

The statement made here is not convincing and is likely to be incorrect. E.g., CUBIC with larger decrease factor would most likely release capacity notably slower than AIMD TCP if there is sudden congestion.

@lisongxu lisongxu self-assigned this Sep 1, 2021
@bbriscoe
Copy link
Contributor

@bbriscoe bbriscoe commented Sep 15, 2021

I agree with Markku that the claim in the draft seems incorrect. Even with fast convergence, each reduction is a little less than Reno. It just needs to admit the difference, rather than saying there is no difference.

@larseggert
Copy link
Member Author

@larseggert larseggert commented Sep 15, 2021

@bbriscoe @markkukojo: would one of you want to propose a PR?

@larseggert
Copy link
Member Author

@larseggert larseggert commented Sep 16, 2021

Or @lisongxu, since he self-assigned this issue?

@goelvidhi
Copy link
Collaborator

@goelvidhi goelvidhi commented Sep 21, 2021

Is it better to just remove congestion from this statement? We already covered congestion events in the rest of the draft.
Suggestion,

If there is a sudden routing change or a mobility event, CUBIC behaves the same as AIMD TCP.

@lisongxu
Copy link
Collaborator

@lisongxu lisongxu commented Sep 21, 2021

Fine with me. Thank, @goelvidhi

@bbriscoe
Copy link
Contributor

@bbriscoe bbriscoe commented Sep 23, 2021

A section on sudden and transient events is meant to discuss
transient events such as sudden congestion, a routing change, or a mobility event.
These are all still about congestion (after all its a congestion control algorithm), so it cannot not discuss congestion. The difference here is the suddenness.

I'll post a PR, as Lars suggests, and see what you think. I'll briefly the difference after a sudden increase and a sudden decrease in capacity, relative to Reno.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants