Make actions set RF path #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dboulware
requested changes
Aug 29, 2022
There was a problem hiding this comment.
Most of these changes are not needed as the existing implementation will handle setting the preselector state if rf_path is in the measurement params. I would recommend we get rid of the unnecessary changes, keep the changes in settings, and consider raising an exception in the base actions configure_preselector method if the sensor has a preselector and no rf_path is specified in the measurment params, or perhaps if the preselector has multiple paths and no rf path is specified.
dboulware
requested changes
Sep 1, 2022
dboulware
requested changes
Sep 1, 2022
dboulware
reviewed
Sep 6, 2022
dboulware
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #35
rf_pathas a required configuration parameter for time domain IQ and single frequency FFT actions if a preselector is defined in the sensor definition filerf_pathbefore measurement in time domain IQ and single frequency FFT actionsImportant:
YAML configs will need to be updated in order to run these actions using a preselector.
rf_path: antenna(or whatever the name of the desired RF path in the preselector configuration file is) to the YAML config of any M4/IQ actions.noise_diode_on: noise_diode_onandnoise_diode_off: noise_diode_off(or whatever the names of the desired states of the preselector are) to the YAML config of any Y-Factor calibration actions.