Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engineers know Door and APC wires from Round start [Merge] #552

Merged
merged 2 commits into from May 14, 2014

Conversation

RemieRichards
Copy link
Contributor

At Roundstart an Engineer (CE, Engi or Atmos)'s Notes are filled with the Wires of APCs and Doors.
Adds an Implant to Syndicate Uplinks to grant them knowledge of Door wires (1 TC cheaper than an Emag because it requires the user to obtain tools)

Codewise:
Adds 3 procs.

  • Get's the name of the object by it's wire datum
  • Deciphers the Randomised Wire list
  • Translate the Deciphered Bitflags into readable english

The SolveWires() proc outputs a string (Text) to an associative list based on the Wire datum passed to the SolveWires() Proc, This text string is valid where all others are, such as Memory procs.

Eg; all_solved_wires[/obj/machinery/door/airlock] contains the translated string from SolveWires()

…iphering wire lists

Adds the Door Knowledge implant to Syndicate implants
Engineers (of all ranks, including Atmos) know APC and Door wires at round start
@ghost
Copy link

ghost commented May 12, 2014

2 is pretty fair, basically makes gloves useless while making a good alternative to the emag. Excellent rob. Might want a [WIP] tag on this.

NTstation13.dme:589:error: unable to open "code/game/objects/items/weapons/implants/implantknowledge.dm".

@RemieRichards
Copy link
Contributor Author

It isn't WIP, but I think I forgot to commit that file, DOH.

@RemieRichards RemieRichards changed the title Engineers know Door and APC wires from Round start [Poll Required] Engineers know Door and APC wires from Round start [Poll Ongoing] May 12, 2014
@Giacom
Copy link
Contributor

Giacom commented May 12, 2014

I'm crying.

@RemieRichards
Copy link
Contributor Author

@Giacom I'm sorry, I tried my best to make it "one size fits all" (as with the SolveWires() proc) but I still needed the Translate proc to be genetic and overridden in the child datums.

Your code babby was beautiful.

/obj/item/weapon/implant/wire_knowledge/implanted(mob/M)
if(!M.mind)
return 0
M.mind.store_memory("If you're reading this, Blame the nearest online Admin")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good joke, but programming is no joke! Basically the feedback is nonsensical garbage, which is cute but isnt practical. You will either puzzle the player or the admin when the player decides to consult the admin.
Give it meaningful feedback or remove it. (Or dont I am not an enemy please dont hate me i am just trying to help)

Of course I am aware that I really have no idea what I am talking about probably and its something like the mob needs to have memory stored or it breaks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No no, I could simply have it return, the message isn't required, but given this item being the base knowledge implant with no design function besides adding a message to the player's mind, it should never be accessed, hence the "blame an Admin" because only an admin could get a blank implanter, faff with an implant case to add the implant to it, and then load the Implanter.

But if it's warranted I can remove it with no issues.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah in that case, its probably cool to keep the message. But it should read something along the lines of (parapharsing this is probably terrible change it to something better than what I say) "An admin has spawned the incorrect class of implanter! Please tell them to spawn a "/obj/item/weapon/implant/wire_knowledge/door" instead."
It could also be an admin message or something, but then you might get something fuckity going on

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like zelacks idea

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really? Considering this dummy implant can't even be used without MASSIVE fuckery like I mentioned, an Admin will immediately realise they need to spawn an implanter with a proper one already in or the syndi kit box.

@ghost
Copy link

ghost commented May 14, 2014

Hey maybe engineers will actually cut malf AIs access out of APCs and doors instead of letting people get crushed in them over and over

@RemieRichards RemieRichards changed the title Engineers know Door and APC wires from Round start [Poll Ongoing] Engineers know Door and APC wires from Round start [Merge] May 14, 2014
Atskadan added a commit that referenced this pull request May 14, 2014
Engineers know Door and APC wires from Round start [Merge]
@Atskadan Atskadan merged commit 491f713 into NTStation:master May 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants