Permalink
Commits on Aug 1, 2013
  1. Merge branch 'hotfix-1.10.3'

    John Dzak committed Aug 1, 2013
  2. Bump version to 1.10.3.

    John Dzak committed Aug 1, 2013
  3. Exclude psu_id and recruit_type from the -4orcing process.

    Addresses #4571.
    
    psu_id and recruit_type are set further up the pipeline (specifically,
    as an ApplyGlobalValuesFilter[1] in ncs_mdes_warehouse).  Setting it
    here interferes with that process.
    
    [1]: https://github.com/NUBIC/ncs_mdes_warehouse/blob/master/lib/ncs_navigator/warehouse/filters/apply_global_values_filter.rb#L45-L61
    (cherry picked from commit 52fa452)
    yipdw committed with John Dzak Jul 23, 2013
  4. A terrible yet workable last-ditch solution for missing values. #4571.

    As we transition data out of NCS Navigator for one of our 1.6.7 sites,
    we have found several situations in which instrument data was truly not
    entered.  InstrumentToWarehouse was designed to fill in these missing
    values with -4 (i.e. "Missing in Error"), but it does not accomplish
    this in all cases.  Some examples:
    
    * responses missing because one part of a multi-part instrument was
      never started
    * responses missing due to some unknown cause (see e.g. [1] if you have
      access to NUBIC's internal issue tracker)
    
    This horrifying, cheesy, yet effective solution makes a last pass over
    the created MDES record, and just fills in -4s where it can.  It farts
    in the general direction of data quality, but we have been told that
    quality now takes a backseat to _just getting the data out_.  Also, it
    works.
    
    This commit has no tests because writing test cases for this sort of
    thing takes longer than just demonstrating it works by running ETL jobs
    on test instances.
    
    [1]: https://code.bioinformatics.northwestern.edu/redmine/issues/show/9680
    (cherry picked from commit 47ff45a)
    yipdw committed with John Dzak Jul 18, 2013
Commits on Jul 31, 2013
  1. Merge pull request #284 from NUBIC/hotfix-1.10.2

    Hotfix 1.10.2
    yipdw committed Jul 31, 2013
  2. 1.10.2

    flockom committed Jul 31, 2013
  3. upgrade surveyor to handle nil datetimes #4603

    see changeset NUBIC/surveyor@v1.4.0...98225cd
    (98225cd is master at this time)
    flockom committed Jul 31, 2013
Commits on Jul 29, 2013
  1. Merge pull request #283 from NUBIC/hotfix-1.10.1

    Hotfix 1.10.1
    yipdw committed Jul 29, 2013
  2. Merge branch 'release-1.10'

    yipdw committed Jul 29, 2013
Commits on Jul 19, 2013
  1. Add blank option on change

    to the disposition list. As this field is required
    whenever the user changes the disposition category
    this will require the user to select a new disposition.
    pfriedman committed Jul 19, 2013
  2. Quick hack to not advance

    the Participant if Participant has completed the
    final 'known' event.
    pfriedman committed Jul 19, 2013
Commits on Jul 18, 2013
  1. Update view #4555

    pfriedman committed Jul 18, 2013
  2. Lo to Hi Analysis #4555

    Broke update_arm method on ParticipantsController into
    three distinct actions and added logging in an attempt to
    better understand the issues surrounding the problems
    seen by westat.
    pfriedman committed Jul 18, 2013
Commits on Jul 16, 2013
  1. Merge pull request #262 from NUBIC/4567-update_contact_disposition_codes

    4567 update contact disposition codes
    jefflunt committed Jul 16, 2013
  2. Update contact dispositions #4567

    on the page based on selected contact type.
    pfriedman committed Jul 16, 2013
  3. Error encountered #4452

    Adding the new option requires a change to the options check
    to allow at least 2 options
    pfriedman committed Jul 16, 2013
  4. bump version to 1.10.0

    pfriedman committed Jul 16, 2013
  5. fix check for invalid codes during ode #4535

    This should solve a category of erros where the code list being
    extracted to in operational data is slightly different than the code
    list in instrument data.
    
    There is an argument for not even extracting these code lists but this
    fix simply prevents trying to extract invalid codes and is the minimal
    change.
    
    also see #4448
    flockom committed with pfriedman Jul 12, 2013
  6. Merge pull request #260 from NUBIC/4456-text_message_contact_disposit…

    …ions
    
    Text message was missing #4456
    phebal committed Jul 16, 2013
  7. Merge pull request #261 from NUBIC/4452-prefix_psu_to_pid

    Prefix psu to ids #4452
    phebal committed Jul 16, 2013
Commits on Jul 15, 2013
  1. Prefix psu to ids #4452

    Prepend the last 3 digits + an underscore to the
    ids generated by the HumanReadableIdGenerator
    pfriedman committed Jul 15, 2013
  2. Text message was missing #4456

    from the list of Survey titles or contact methods
    used to determine the disposition category.
    pfriedman committed Jul 15, 2013
  3. Merge pull request #259 from NUBIC/3450_develop_mold_question_show_18M

    18MonthMother Display Mold Question V3 Dependency #3450
    phebal committed Jul 15, 2013
Commits on Jul 12, 2013
  1. 18M Display Mold Question Dependency #3450

    this resolves question to show for mdes version 3
    georgediaz88 committed Jul 11, 2013
Commits on Jul 11, 2013
  1. Merge branch 'hotfix-1.9.4' into develop

    Conflicts:
    	lib/ncs_navigator/core/version.rb
    pfriedman committed Jul 11, 2013
  2. Merge branch 'hotfix-1.9.4'

    pfriedman committed Jul 11, 2013
  3. Remove required and add -4 option #4553

    As part of hot fix 1.9.4 we were asked to remove the mandatory flag
    on four fields on the Event form. In addition, to make it easier for data
    collectors to understand the value for these not required fields we
    re-added 'Missing in Error' as an option to the select list for code list
    attributes.
    pfriedman committed Jul 11, 2013
  4. bump hot fix version 1.9.4

    pfriedman committed Jul 11, 2013
Commits on Jul 10, 2013
  1. Merge branch 'hotfix-1.9.3' into develop

    Conflicts:
    	lib/ncs_navigator/core/version.rb
    pfriedman committed Jul 10, 2013
  2. Merge branch 'hotfix-1.9.3'

    Conflicts:
    	lib/ncs_navigator/core/version.rb
    pfriedman committed Jul 10, 2013