Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make surveyor install on Rails 4.0 #460

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
6 participants
Contributor

PragTob commented Jun 30, 2013

However it doesn't work, as there seems to be a problem with formtastic or something... at least I can not run the migrations.

Cheers,
Tobi

rwjblue commented Jul 1, 2013

Looks like the main entry point only loads the engine if Rails::VERSION::MAJOR == 3. I haven't tested, but you may need to change this also.

require 'surveyor/engine' if defined?(Rails) && Rails::VERSION::MAJOR == 3

Contributor

ferrisoxide commented Jul 11, 2013

Am working on this myself. Have all the rspec's passing - now on to getting a full rails 4 app to verify against. See https://github.com/ferrisoxide/surveyor on the develop branch. Very much a work in progress

Contributor

PragTob commented Jul 11, 2013

Cool @ferrisoxide - thanks for chiming in. Would be cool to hear some statements from the maintainers.

Owner

yoon commented Jul 11, 2013

Our group is hard at work on one of the apps that uses surveyor, and we haven't had a chance to take a look at this yet. Thanks for the contribution!

Contributor

caboteria commented Aug 16, 2013

I have added more Rails4 fixes to @ferrisoxide's work, which was a great start. The rspec tests now pass and we're down to a single deprecation warning. I opened a pull request back to his fork, so hopefully he can be a point of focus for Rails4 changes. If he opts not to, I'll do it.

Contributor

ferrisoxide commented Aug 19, 2013

Hi @caboteria. I'd love to help out, but I'm not sure I can provide consistent support for the Rails 4 changes (and I don't want to disappoint anyone). But thank you for asking.

I am planning on doing some extra work - mainly to get rid the requirement for the protected_attributes gem - and I'll let you know when I've done so. But I can't say when I'll get around to it. :(

Contributor

caboteria commented Aug 19, 2013

Thanks for getting the Rails4 ball rolling @ferrisoxide, I'll keep chipping away at it. If you get the protected_attribute stuff worked out, please send me a pull.

Contributor

ferrisoxide commented Jan 15, 2014

I'll have some time to work on the Rails 4 port next week. Sorry for the general slackness - just busy on other things. Good work @caboteria for pushing this along.

Owner

yoon commented Mar 23, 2014

@ferrisoxide and @caboteria thanks for your contributions! See the rails4 branch.

@yoon yoon closed this Mar 23, 2014

Contributor

caboteria commented Mar 24, 2014

Great to see activity on this, thanks @yoon. I'd be curious to find out what your plans are for Rails 4 (and I think others would be, too).

The changes I'm using to get Surveyor to work with Rails 4 are in the pull request in issue #468. Hope they're useful to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment