Fix false positive for Question#triggered? #469

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
1 participant

I'm working on enforcing mandatory questions, and I noticed that questions without explicit dependencies inside of question groups with dependencies were erroneously reporting themselves to be triggered, which prevented a user from moving on in the survey.

This issue probably needs to be addressed inside ResponseSet#progress_hash as well.

serracorwin added some commits Jan 6, 2014

Fix false positive for Question#triggered?
I'm working on enforcing mandatory questions, and I noticed that questions without explicit dependencies inside of question groups with dependencies were erroneously reporting themselves to be triggered, which prevented a user from moving on in the survey.

This issue probably needs to be addressed inside `ResponseSet#progress_hash` as well.
Fix false positive in ResponseSet#is_unanswered?
Questions with the label display type cannot be answered, but is_answered? was returning true. Since I'm relying on is_unanswered? for enforcing mandatory questions, it makes more sense for it to return false for labels.

@tparsnick tparsnick referenced this pull request in HeHStudy/surveyor Mar 4, 2014

Closed

Build out validations in UI #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment