Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Cloud embeds sometimes overlap next/prev page and full-screen #330

Open
JoeGermuska opened this issue Jan 19, 2016 · 4 comments
Open

Comments

@JoeGermuska
Copy link
Member

A Zendesk user reported that sometimes the "next/previous" controls for a DC embed overlap with the "full screen" control.

image

I'm not sure if this is something we can control, but we should explore, or contact @knowtheory and co to see what they say

@knowtheory
Copy link

@JoeGermuska btw, in very small contexts would there be any interest in using our page embed type? http://documentcloud.github.io/documentcloud-pages/examples/

@scott2b scott2b added the media label Apr 11, 2017
@scott2b scott2b modified the milestone: media & language Apr 11, 2017
@rosaliechan rosaliechan self-assigned this May 1, 2017
@rosaliechan
Copy link

I was looking into this today and it seems like it's not really something we can control @JoeGermuska. I could explore this more tomorrow though

@rosaliechan
Copy link

I set a minimum width so that the arrow does not overlap with the full screen.
However, the issue when I did that was that the text on the right would sometimes go under the documentcloud embed. To resolve this, I changed skinny_size from 650 to 770. Thoughts on this? @scott2b
You can view the pull request here: #519

@rosaliechan
Copy link

@knowtheory we might be interested. Is there a link to the source code for that style?

@JoeGermuska JoeGermuska removed this from the media & language milestone Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants