-
Notifications
You must be signed in to change notification settings - Fork 556
docs: edit 1483 #1489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: edit 1483 #1489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Greptile Summary
Refines the LLM reasoning traces documentation with improved structure and clarity. Key changes include converting the warning directive to a deprecated directive for better semantic accuracy, restructuring the "Accessing Reasoning Traces" section with clearer decision guidance upfront, adding descriptive subheadings throughout, improving bullet point formatting with periods for consistency, and enhancing code example explanations with more detailed context and expected outputs.
Confidence Score: 5/5
- This PR is safe to merge with minimal risk - documentation-only changes improve clarity without affecting code behavior
- This PR contains only documentation improvements with no code changes. The edits enhance readability, use appropriate directive syntax (
deprecatedinstead ofwarning), add helpful structure with better headings and formatting, and provide clearer guidance for users choosing between API patterns - No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| docs/user-guides/configuration-guide/llm-configuration.md | 5/5 | Documentation improvements: better structure, clearer examples, improved readability with consistent formatting and organization |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant Doc as Documentation
participant User as End User
Dev->>Doc: Edit PR #1483 content
Note over Doc: Change warning to deprecated
Note over Doc: Restructure examples
Note over Doc: Add clearer headings
Note over Doc: Improve bullet formatting
Doc->>User: Present improved docs
Note over User: Better understanding of:<br/>- GenerationOptions usage<br/>- Reasoning traces setup<br/>- Configuration patterns
1 file reviewed, no comments
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Greptile Summary
This PR improves the LLM configuration documentation by enhancing clarity, organization, and readability. Key changes include:
- Changed the breaking change warning to a proper deprecated directive for the
reasoning_configfield - Reorganized the "Guardrailing Reasoning Traces" section with a new "Prepare Configuration Files" subsection using numbered steps
- Improved explanation of when the NeMo Guardrails toolkit extracts reasoning traces and how to access them via
$bot_thinkingandbot_thinkingvariables - Moved the "which pattern to use" guidance earlier in the "Accessing Reasoning Traces in API Responses" section for better flow
- Enhanced Python code examples with detailed inline comments explaining each step
- Added example outputs to demonstrate the expected results
- Improved consistency in formatting with proper punctuation and clearer language throughout
All changes are editorial improvements that make the documentation more accessible and easier to follow without altering any technical content or functionality.
Confidence Score: 5/5
- This PR is safe to merge with no risk - it contains only documentation improvements
- The PR only modifies documentation with editorial improvements for clarity and readability. No code changes, no functionality changes, and no technical accuracy issues were found. The changes properly use the deprecated directive, improve section organization, and enhance code examples with helpful comments.
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| docs/user-guides/configuration-guide/llm-configuration.md | 5/5 | Documentation improvements for clarity, structure, and readability; changed warning to deprecated directive; enhanced section organization |
Sequence Diagram
sequenceDiagram
participant User as Documentation Reader
participant Doc as llm-configuration.md
participant Config as config.yml
participant Prompts as prompts.yml
participant API as NeMo Guardrails API
User->>Doc: Read documentation changes
Note over Doc: Changed warning to deprecated directive<br/>Improved structure and clarity
Doc->>User: Learn about reasoning traces setup
Note over Doc: Added subsection "Prepare Configuration Files"<br/>Reorganized content with numbered steps
User->>Config: Configure output rails
Note over Config: Set up main model and self_check_output
User->>Prompts: Configure prompts for reasoning access
Note over Prompts: Use bot_thinking variable
User->>Doc: Learn API response patterns
Note over Doc: Clarified when to use each pattern<br/>Moved guidance earlier in section
User->>API: Call with GenerationOptions
API-->>User: Return structured GenerationResponse
Note over API: reasoning_content + response fields
User->>API: Call without GenerationOptions
API-->>User: Return string with <think> tags
Note over API: Inline reasoning in response
1 file reviewed, no comments
11010d0
into
NVIDIA-NeMo:docs/llm-configuration-update
Description
Edits #1483
Related Issue(s)
Checklist