Skip to content

Fix select model type and custom prompts task.py #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drazvan merged 3 commits into from
Jul 10, 2024
Merged

Fix select model type and custom prompts task.py #486

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50ae55b
Update prompts.py
cyun9601 May 8, 2024
c8c3e29
Fix select model type and custom prompts task.py
cyun9601 May 8, 2024
c519a1d
Update prompts.py
cyun9601 May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions nemoguardrails/llm/prompts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,18 +114,20 @@ def _get_prompt(

def get_prompt(config: RailsConfig, task: Union[str, Task]) -> TaskPrompt:
"""Return the prompt for the given task."""
# Currently, we use the main model for all tasks
# TODO: add support to use different models for different tasks

# Fetch current task parameters like name, models to use, and the prompting mode
task_name = str(task.value) if isinstance(task, Task) else task

task_model = "unknown"
if config.models:
task_model = config.models[0].engine
if config.models[0].model:
task_model += "/" + config.models[0].model

_models = [model for model in config.models if model.type == task_name]
if not _models:
_models = [model for model in config.models if model.type == "main"]

task_model = _models[0].engine
if _models[0].model:
task_model += "/" + _models[0].model

task_prompting_mode = "standard"
if config.prompting_mode:
# if exists in config, overwrite, else, default to "standard"
Expand Down