-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reshape op #1327
Reshape op #1327
Conversation
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Add tests. Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
!build |
CI MESSAGE: [925438]: BUILD STARTED |
CI MESSAGE: [925438]: BUILD PASSED |
Add comparison to TensorLayout in pybind. Expose TensorMeta from TensorList and TensorVector. Propagate TensorMeta when sharing tensor data from TensorList. Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
!build |
CI MESSAGE: [926752]: BUILD STARTED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, except for the couple of comments that are not yet resolved
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
!build |
CI MESSAGE: [926780]: BUILD STARTED |
CI MESSAGE: [926752]: BUILD PASSED |
CI MESSAGE: [926780]: BUILD PASSED |
* Reshape operator which reinterprets data without copying. * Fix output layout in Reshape. * Expose Tensor and TensorList layout in Python * Add comparison to TensorLayout in pybind. * Expose TensorMeta from TensorList and TensorVector. * Propagate TensorMeta when sharing tensor data from TensorList. * Add ShareData to TensorVector. Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com> Signed-off-by: Jianjun Liu <00liujj@163.com>
Why we need this PR?
It adds new feature requested by the community:
What happened in this PR?
JIRA TASK: [DALI-XXXX]