Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix color operators. #1555

Merged
merged 1 commit into from Dec 9, 2019
Merged

Fix color operators. #1555

merged 1 commit into from Dec 9, 2019

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Dec 9, 2019

Signed-off-by: Michal Zientkiewicz michalz@nvidia.com

Why we need this PR?

Pick one

  • It fixes a bug:
    • memory corruption in BrightnessContrast
    • lost layout info in BrightnessContrast and HSV

What happened in this PR?

  • Explain solution of the problem, new feature added.
  • What was changed, added, removed?
  • What is most important part that reviewers should focus on?
    • BrightnessContrast kernel: loop boundaries
    • HSV, BrightnessContrast: propagate layout
    • HSV: enforce input layout
  • Was this PR tested? How?
    • Existing tests apply and actually detected the bugs
  • Were docs and examples updated, if necessary?
    • N/A

JIRA TASK: N/A

@mzient
Copy link
Contributor Author

mzient commented Dec 9, 2019

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1023850]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1023850]: BUILD FAILED

@mzient
Fix color operators.
0ba8b46 
* BrightnessContrast kernel: loop boundaries
* HSV, BrightnessContrast: propagate layout
* HSV: enforce input layout

Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
@mzient
Copy link
Contributor Author

mzient commented Dec 9, 2019

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1023906]: BUILD STARTED

@mzient
Copy link
Contributor Author

mzient commented Dec 9, 2019

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1023909]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1023909]: BUILD PASSED

@mzient mzient merged commit 614b829 into NVIDIA:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jantonguirao jantonguirao jantonguirao approved these changes

@JanuszL JanuszL JanuszL approved these changes

@szalpal szalpal Awaiting requested review from szalpal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mzient @dali-automaton @jantonguirao @JanuszL