Update augmentation gallery

[jantonguirao]

Signed-off-by: Joaquin Anton janton@nvidia.com

Why we need this PR?

Pick one, remove the rest

• It updates the augmentation gallery notebook showing other operators (erase, slice)

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

• What solution was applied:
  Added operators to augmentation gallery, changed the seed to pick an image that produces appealing augmentation results.
• Affected modules and functionalities:
  Documentation
• Key points relevant for the review:
  NA
• Validation and testing:
  NA
• Documentation (including examples):
  NA

JIRA TASK: [Use DALI-XXXX or NA]

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

JanuszL commented on 2021-02-23T18:30:39Z
----------------------------------------------------------------

1) Can we move to fn API?

2) Maybe we should remove resize as it doesn't show anything in this mosaic.

jantonguirao commented on 2021-02-25T15:46:08Z
----------------------------------------------------------------

Done

JanuszL commented on 2021-02-25T17:06:46Z
----------------------------------------------------------------

I mean to get rid of the class and use the decorator if possible. Variant with define_graph is not something we want to advertise as the recommended way.

jantonguirao commented on 2021-02-26T09:12:06Z
----------------------------------------------------------------

Done

[jantonguirao]

View / edit / reply to this conversation on ReviewNB

JanuszL commented on 2021-02-23T18:30:39Z

1. Can we move to fn API?

2. Maybe we should remove resize as it doesn't show anything in this mosaic.

Done

[jantonguirao]

Done

---

View entire conversation on ReviewNB

[JanuszL]

I mean to get rid of the class and use the decorator if possible. Variant with define_graph is not something we want to advertise as the recommended way.

---

View entire conversation on ReviewNB

[jantonguirao]

Done

---

View entire conversation on ReviewNB

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

banasraf commented on 2021-02-26T14:46:45Z
----------------------------------------------------------------

• Just a suggestion:

outs = [lables, images]
for aug in augmentations.values():
  outs += [aug(images)]
return tuple(outs)

to

return tuple([labels, images] + [aug(images) for aug in augmentations.values()])

or

outs = [labels, images]
outs += [aug(images) for aug in augmentations.values()]
return tuple(outs)

• From what I remember this device = 'gpu' argument is not needed. The device can be inferred.
• Also, I think in Python style, no space around = is preferred for keyword arguments, but I guess it's ok as long as it's consistent

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

banasraf commented on 2021-02-26T14:46:46Z
----------------------------------------------------------------

inconsistency in spacing around = (device_id=0, seed=111222)

[jantonguirao]

!build

[dali-automaton]

CI MESSAGE: [2113170]: BUILD STARTED

[dali-automaton]

CI MESSAGE: [2113170]: BUILD PASSED

[jantonguirao]

!build

[dali-automaton]

CI MESSAGE: [2124227]: BUILD STARTED

[dali-automaton]

CI MESSAGE: [2124227]: BUILD PASSED