Fix device selection in PipelinedExecutor. #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanuszL
reviewed
Dec 11, 2018
| @@ -75,6 +75,7 @@ void Executor::RunCPU() { | |||
| lock.unlock(); | |||
|
|
|||
| // Run the support ops | |||
| DeviceGuard g(device_id_); | |||
There was a problem hiding this comment.
Please put it above comment, now it is misleading.
JanuszL
reviewed
Dec 11, 2018
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
JanuszL
approved these changes
Dec 12, 2018
|
Added Build 591988 passed. |
Kh4L
reviewed
Dec 12, 2018
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CUDA device id was not properly set in executor (it always tried to run on device 0). It's been fixed with RAII DeviceGuard in all relevant functions.
Signed-off-by: Michal Zientkiewicz michalz@nvidia.com