Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an info about fill_values being used by pad_output in crop_mirror_normalize #3674

Merged
merged 2 commits into from Feb 14, 2022

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Feb 11, 2022

  • the crop_mirror_normalize documentation is not precise regarding the value
    used when pad_output is set. This PR adds a note that fill_values
    value is used

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • the crop_mirror_normalize documentation is not precise regarding the value
    used when pad_output is set. This PR adds a note that fill_values
    value is used

Additional information:

Affected modules and functionalities:

  • crop_mirror_normalize documentation

Key points relevant for the review:

  • wording

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

…rror_normalize

- the crop_mirror_normalize documentation is not precise regarding the value
  used when `pad_output` is set. This PR adds a note that `fill_values`
  value is used

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented Feb 11, 2022

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3944315]: BUILD STARTED

Comment on lines 50 to 51
R"code(Determines whether to pad the output using ``fill_values`` value to the number
of channels as a power of 2).)code", false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Determines whether to pad the output so that the number of channels is a power of 2. The value used for padding is determined by the fill_values argument.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3944315]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3944315]: BUILD PASSED

@JanuszL
Copy link
Contributor Author

JanuszL commented Feb 14, 2022

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3958114]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3958114]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3958114]: BUILD PASSED

@JanuszL JanuszL merged commit f7d0614 into NVIDIA:main Feb 14, 2022
@JanuszL JanuszL deleted the improve_crop_docs branch February 14, 2022 17:19
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
…rror_normalize (NVIDIA#3674)

- the crop_mirror_normalize documentation is not precise regarding the value
  used when `pad_output` is set. This PR adds a note that `fill_values`
  value is used

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
…rror_normalize (NVIDIA#3674)

- the crop_mirror_normalize documentation is not precise regarding the value
  used when `pad_output` is set. This PR adds a note that `fill_values`
  value is used

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
…rror_normalize (NVIDIA#3674)

- the crop_mirror_normalize documentation is not precise regarding the value
  used when `pad_output` is set. This PR adds a note that `fill_values`
  value is used

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants