Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip JPEG lossless tests for compute capability < SM60 #4600

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

jantonguirao
Copy link
Contributor

Category:

Other

Description:

  • It skips JPEG lossless tests on unsupported HW (<SM60)

Additional information:

Affected modules and functionalities:

experimental.decoders.image

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@jantonguirao jantonguirao force-pushed the nvjpeg_lossless4 branch 2 times, most recently from f2d472c to 08aa246 Compare January 23, 2023 17:37
@JanuszL JanuszL self-assigned this Jan 23, 2023
@klecki klecki self-assigned this Jan 23, 2023
@jantonguirao
Copy link
Contributor Author

!build

Copy link
Contributor

@mzient mzient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't introduce the dependency on NVML - cudaGetDeviceProperties is enough to get the device's compute capability.

Signed-off-by: Joaquin Anton <janton@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7086402]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7086447]: BUILD STARTED

Signed-off-by: Joaquin Anton <janton@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7087093]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7087093]: BUILD PASSED

@jantonguirao jantonguirao merged commit 51d6ff9 into NVIDIA:main Jan 23, 2023
aderylo pushed a commit to zpp-dali-2022/DALI that referenced this pull request Mar 17, 2023
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@JanuszL JanuszL mentioned this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants