Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constant operator: Set proper stream in constant storage. #4643

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Feb 8, 2023

Signed-off-by: Michal Zientkiewicz michalz@nvidia.com

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

The constant storage had an improper stream and it was shared as the operator's output, which might lead to premature deletion of the storage.

Additional information:

Affected modules and functionalities:

Constant op.

Key points relevant for the review:

Tests:

operator_1/test_constant.py - multiple GPU tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: DALI-3248

Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7235873]: BUILD STARTED

@JanuszL JanuszL self-assigned this Feb 8, 2023
@mzient mzient changed the title Set proper stream in constant storage. constant operator: Set proper stream in constant storage. Feb 8, 2023
@jantonguirao jantonguirao self-assigned this Feb 8, 2023
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7235873]: BUILD PASSED

@mzient mzient merged commit a542402 into NVIDIA:main Feb 9, 2023
aderylo pushed a commit to zpp-dali-2022/DALI that referenced this pull request Mar 17, 2023
)

Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants