Fix random bounding box crop #512
Merged
+89
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
mzient
reviewed
Feb 5, 2019
| @@ -129,20 +133,25 @@ void RandomBBoxCrop<CPUBackend>::RunImpl(SampleWorkspace *ws, const int) { | |||
| labels.emplace_back(*label_data); | |||
| } | |||
|
|
|||
| const auto prospective_crop = | |||
| FindProspectiveCrop(bounding_boxes, labels, SelectMinimumOverlap()); | |||
| while (true) { | |||
There was a problem hiding this comment.
Use some reasonable value for max. number of attempts (100?) if allow_no_crop is not specified - otherwise this function may hang.
There was a problem hiding this comment.
I'm a bit worried about changing this default value, as it severely degrades training accuracy. Additionally, with default threshold 0 and default allow_no_crop to true the problem should be somewhat alleviated. Maybe I add some info about this to op doc string? To be careful with these parameters and why.
There was a problem hiding this comment.
while(true)? where is the break condition?
There was a problem hiding this comment.
There was a return statement, but the whole thing was rather clumsy. I added constructor for ProspectiveCrop and refactored it to make it more readable and easier to follow.
mzient
reviewed
Feb 5, 2019
Signed-off-by: Albert Wolant <awolant@nvidia.com>
jantonguirao
reviewed
Feb 5, 2019
| @@ -129,20 +133,25 @@ void RandomBBoxCrop<CPUBackend>::RunImpl(SampleWorkspace *ws, const int) { | |||
| labels.emplace_back(*label_data); | |||
| } | |||
|
|
|||
| const auto prospective_crop = | |||
| FindProspectiveCrop(bounding_boxes, labels, SelectMinimumOverlap()); | |||
| while (true) { | |||
There was a problem hiding this comment.
while(true)? where is the break condition?
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
mzient
reviewed
Feb 5, 2019
Signed-off-by: Albert Wolant <awolant@nvidia.com>
awolant
force-pushed
the
fix_bbox_crop
branch
from
3aa87fe
to
b21c4fd
Compare
|
Builds 624482 |
mzient
reviewed
Feb 6, 2019
mzient
approved these changes
Feb 6, 2019
Signed-off-by: Albert Wolant <awolant@nvidia.com>
awolant
force-pushed
the
fix_bbox_crop
branch
from
3454354
to
ee9932b
Compare
|
Builds 625254 |
Kh4L
approved these changes
Feb 6, 2019
awolant
force-pushed
the
fix_bbox_crop
branch
from
876b28a
to
000b59d
Compare
Signed-off-by: Albert Wolant <awolant@nvidia.com>
awolant
force-pushed
the
fix_bbox_crop
branch
from
000b59d
to
b9b8c89
Compare
|
Builds 625321 |
haoxintong
pushed a commit
to haoxintong/DALI
that referenced
this pull request
Jul 16, 2019
* Fix RandomBBox crop Signed-off-by: Albert Wolant <awolant@nvidia.com> * Add sample options Signed-off-by: Albert Wolant <awolant@nvidia.com> * Fix lint errors Signed-off-by: Albert Wolant <awolant@nvidia.com> * Add ProspectiveCrop as struct Signed-off-by: Albert Wolant <awolant@nvidia.com> * Refactored FindProspectiveCrop calls Signed-off-by: Albert Wolant <awolant@nvidia.com> * Fixed indentations Signed-off-by: Albert Wolant <awolant@nvidia.com> * Add comment to explain sample_options_ Signed-off-by: Albert Wolant <awolant@nvidia.com> * Improved docs Signed-off-by: Albert Wolant <awolant@nvidia.com> * Removed _ from fields names in ProspectiveCrop Signed-off-by: Albert Wolant <awolant@nvidia.com> * Refactor ProspectiveCrop defautl ctor Signed-off-by: Albert Wolant <awolant@nvidia.com> * Address review comments Signed-off-by: Albert Wolant <awolant@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.