Skip to content

Add xatt trimming for multitask beam decoding#15466

Merged
nithinraok merged 9 commits into
NVIDIA-NeMo:mainfrom
azziko:fix-xatt-trimming
Apr 23, 2026
Merged

Add xatt trimming for multitask beam decoding#15466
nithinraok merged 9 commits into
NVIDIA-NeMo:mainfrom
azziko:fix-xatt-trimming

Conversation

@azziko
Copy link
Copy Markdown
Contributor

@azziko azziko commented Mar 5, 2026

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Adds a missing trimming of the cross-attention for multitask beam decoding

Collection: [ASR]

Changelog

  • Trim pads and eos from cross-attention.

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • [x ] Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

This PR is related to #15419 and #15229

Signed-off-by: azziko <sharipov.wdev@gmail.com>
@github-actions github-actions Bot added the ASR label Mar 5, 2026
azziko and others added 2 commits March 5, 2026 13:14
@mgaido91
Copy link
Copy Markdown
Contributor

mgaido91 commented Mar 5, 2026

The change looks good to me, I'd add a UT though, thanks!

azziko and others added 2 commits March 5, 2026 18:30
Signed-off-by: azziko <sharipov.wdev@gmail.com>
Signed-off-by: azziko <azziko@users.noreply.github.com>
@azziko
Copy link
Copy Markdown
Contributor Author

azziko commented Mar 7, 2026

Hello @nithinraok,

Could you please review the PR?

@chtruong814 chtruong814 added the needs-follow-up Issue needs follow-up label Mar 9, 2026
Copy link
Copy Markdown
Member

@nithinraok nithinraok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thanks

@nithinraok nithinraok enabled auto-merge (squash) March 13, 2026 13:25
@chtruong814 chtruong814 added Run CICD waiting-on-customer Waiting on the original author to respond needs-follow-up Issue needs follow-up and removed Run CICD needs-follow-up Issue needs follow-up waiting-on-customer Waiting on the original author to respond labels Apr 18, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added waiting-on-maintainers Waiting on maintainers to respond and removed needs-follow-up Issue needs follow-up labels Apr 21, 2026
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 22, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@nithinraok nithinraok merged commit 44c17e0 into NVIDIA-NeMo:main Apr 23, 2026
153 checks passed
@blisc
Copy link
Copy Markdown
Collaborator

blisc commented Apr 23, 2026

Thanks for you contribution!

@svcnvidia-nemo-ci svcnvidia-nemo-ci removed the waiting-on-maintainers Waiting on maintainers to respond label Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants