`CLAUDE.md`, PR babysitter, local dev skills + symlinks for Codex/Cursor by pzelasko · Pull Request #15613 · NVIDIA-NeMo/NeMo

pzelasko · 2026-04-15T22:37:16Z

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add CLAUDE.md and symlinks for Codex/Cursor - my first take anyway, provides minimal guidance for NeMo Speech usage and development.
I symlinked CLAUDE.md -> AGENTS.md and .claude/skills to .codex/skill and .cursor/skills, and checked that the existing skills are correctly discovered by all three harnesses.
There's also a post-hook for Claude that makes it run linters after every change with the same rules as in repo CI checks (i.e. don't touch files that weren't modified).
a GitHub Action for babysitting PRs (getting to green CI semi-autonomously)
three skills /verify, /babysit-pr and /fix-issue - intended for local development use with a harness if that's preferable to triggering it through GH actions

PR babysitter GH action logic:

When there is a check failure, and Has Babysitter label is set, the agent will debug and post a comment with fix plan, pinging the PR author. The author can respond in a comment or react with a 👍🏻 emoji on the agent's comment. The agent determines the response and if approved, implements the plan. At any time this can be disabled by removing Has Babysitter label. The agent uses Agent Plan Pending Approval and Agent Plan Approved labels on the to manage state, and cleans them up after PR is merged.

Collection: [Note which collection this PR will affect]

Changelog

Add CLAUDE.md and symlinks for Codex/Cursor

Usage

You can potentially add a usage example below

# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

Make sure you read and followed Contributor guidelines
Did you write any new necessary tests?
Did you add or update any necessary documentation?
Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

New Feature
Bugfix
Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Related to # (issue)

Signed-off-by: Piotr Żelasko <petezor@gmail.com>

pzelasko · 2026-04-15T22:43:09Z

/claude review

claude · 2026-04-15T22:45:05Z

+        "matcher": "Write|Edit",
+        "hooks": [
+          {
+            "type": "command",


Bug: The directory-filter case patterns (docs/*, nemo/collections/*, etc.) are relative, but tool_input.file_path from Claude Code's Write/Edit tools is always an absolute path (e.g. /home/user/NeMo/nemo/collections/asr/foo.py). Since bash case matching requires docs/* to match from the start of the string, none of these exclusions will ever trigger — so black/isort will run on every .py file, including the collections that pyproject.toml extend-exclude is supposed to skip.

One fix: strip the path to repo-relative before the filter, e.g.:

Suggested change

"type": "command",

"command": "jq -r '.tool_input.file_path' | { read -r f; f=\"${f#\"$(git rev-parse --show-toplevel)/\"}\"; case \"$f\" in *.py) ;; *) exit 0;; esac; case \"$f\" in docs/*|external/*|examples/*) exit 0;; nemo/collections/speechlm2/*) ;; nemo/collections/*) exit 0;; esac; black --quiet \"$f\"; isort --quiet \"$f\"; } 2>/dev/null || true",

Or use wildcard prefixes like */docs/* in the patterns.

github-actions · 2026-04-16T11:28:40Z

[🤖]: Hi @pzelasko 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

vmendelev

Great first step!

Signed-off-by: Piotr Żelasko <petezor@gmail.com>

pzelasko · 2026-04-16T16:25:50Z

@nithinraok @vmendelev I addressed your reviews.
I also added:

a GitHub Action for babysitting PRs (getting to green CI autonomously)
two skills /babysit-pr and /fix-issue - intended for local development use with a harness if that's preferable to triggering it through GH actions

github-actions · 2026-04-16T16:27:48Z

I'm taking over this PR. I'll ping the author if I can't figure it out.

github-actions · 2026-04-16T16:27:50Z

I'm taking over this PR. I'll ping the author if I can't figure it out.

Signed-off-by: Piotr Żelasko <petezor@gmail.com>

nithinraok · 2026-04-16T17:01:51Z

/claude review

nithinraok

Great work towards automating!

Signed-off-by: Piotr Żelasko <petezor@gmail.com>

github-actions · 2026-04-16T19:56:27Z

[🤖]: Hi @pzelasko 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

Signed-off-by: Piotr Żelasko <petezor@gmail.com>

pzelasko · 2026-04-16T21:56:09Z

Following offline discussion about this PR with @chtruong814, we decided to make the PR babysitter GH action less autonomous for now. New logic:

When there is a check failure, and Has Babysitter label is set, the agent will debug and post a comment with fix plan, pinging the PR author. The author can respond in a comment or react with a 👍🏻 emoji on the agent's comment. The agent determines the response and if approved, implements the plan. At any time this can be disabled by removing Has Babysitter label. The agent uses Agent Plan Pending Approval and Agent Plan Approved labels on the to manage state, and cleans them up after PR is merged.

chtruong814

I just focused on the github action. main concern is the authorization check and ensuring this overall workflow does not run if someone is not a speech team member.

chtruong814 · 2026-04-16T22:19:59Z

+  issue_comment:
+    types: [created]
+  schedule:
+    - cron: '*/5 * * * *'


Why does this need to run on a schedule?

It was to detect the 👍🏻 emoji. I decided to drop this to simplify - approval can now be only done via comment.

chtruong814 · 2026-04-16T22:23:16Z

+  issues: write
+  id-token: write
+
+jobs:


We probably should have checks that this is only running on branches or PRs for internal users. The claude code action should also have a check on the user that triggers the event has write access. But there's a lot going on here, and I think we should ensure nothing happens if it's for forks/external contributors.

Hardened every step with a "preflight" verification

chtruong814 · 2026-04-16T22:24:59Z

+       contains(github.event.pull_request.labels.*.name, 'Has Babysitter')) ||
+      (github.event_name == 'pull_request_review' &&
+       contains(github.event.review.body, '@claude') &&
+       contains(github.event.pull_request.labels.*.name, 'Has Babysitter'))


We may need to check for a specific @claude /command because there may be other claude actions in this repo that could inadvertently trigger this.

The other actions are /claude so they don't conflict. I'd rather keep this as natural language thing, we might want to evolve this into a chat later.

chtruong814 · 2026-04-16T22:25:55Z

+              }
+            } catch (e) {
+              core.setFailed(`${username} is not a member of NVIDIA Speech Team`);
+            }


oh great. you do have this check.

chtruong814 · 2026-04-16T22:34:08Z

+      github.event_name == 'pull_request' &&
+      github.event.action == 'labeled' &&
+      github.event.label.name == 'Agent Plan Approved' &&
+      contains(github.event.pull_request.labels.*.name, 'Has Babysitter')


I think anyone can add a label? So this would get triggered if someone adds Has Babysitter and then Agent Plan Approved. I guess someone manually adding the label is also approving? And in theory nothing happens if there's no ` comment?

Hardened against this

chtruong814 · 2026-04-16T22:37:48Z

+              context.payload.comment?.user?.login ||
+              context.payload.review?.user?.login;
+            try {
+              const res = await github.rest.teams.getMembershipForUserInOrg({


I feel this should probably happen as a prequisite for all the jobs in the workflow?

Addresses Charlie's review on #15613. Adds per-job preflights that verify the acting user (label sender / approval commenter / execute-fix sender) is an active NVIDIA-NeMo/speech_team member, and fork-guards every PR-scoped job so the babysitter never runs on forks. Also blocks manual-label bypass by requiring a bot-authored plan comment before execute-fix proceeds, and drops the cron+reaction approval path in favor of natural-language replies. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

pzelasko · 2026-04-17T14:24:40Z

@chtruong814 addressed review, see 318c08b

pzelasko · 2026-04-17T23:39:24Z

Bypassing CI - the PR doesn't touch any code

Add CLAUDE.md and symlinks for Codex/Cursor

bae58f7

Signed-off-by: Piotr Żelasko <petezor@gmail.com>

pzelasko requested review from artbataev, blisc, nithinraok and vmendelev April 15, 2026 22:37

pzelasko added the Run CICD label Apr 15, 2026

pzelasko temporarily deployed to test April 15, 2026 22:39 — with GitHub Actions Inactive

claude Bot reviewed Apr 15, 2026

View reviewed changes

github-actions Bot removed the Run CICD label Apr 16, 2026

vmendelev reviewed Apr 16, 2026

View reviewed changes

Comment thread CLAUDE.md

vmendelev self-requested a review April 16, 2026 12:22

vmendelev previously approved these changes Apr 16, 2026

View reviewed changes

nithinraok reviewed Apr 16, 2026

View reviewed changes

Comment thread .claude/skills/verify/SKILL.md

Comment thread CLAUDE.md Outdated

Address review + babysit PR action + 2 skills (babysit-pr, fix-issue)

ca57087

Signed-off-by: Piotr Żelasko <petezor@gmail.com>

pzelasko dismissed vmendelev’s stale review via ca57087 April 16, 2026 16:22

github-actions Bot added the CI label Apr 16, 2026

pzelasko added Has Babysitter Claude autonomously takes over the quest to get to a green CI. labels Apr 16, 2026

chtruong814 added the Run CICD label Apr 16, 2026

pzelasko requested review from chtruong814 April 16, 2026 16:28

chtruong814 had a problem deploying to test April 16, 2026 16:28 — with GitHub Actions Error

Fix double-posting of 'taking over' comment and change the text

ae5ee67

Signed-off-by: Piotr Żelasko <petezor@gmail.com>

pzelasko added Run CICD and removed Run CICD labels Apr 16, 2026

pzelasko temporarily deployed to test April 16, 2026 16:52 — with GitHub Actions Inactive

pzelasko changed the title ~~Add CLAUDE.md and symlinks for Codex/Cursor~~ CLAUDE.md, PR babysitter, local dev skills + symlinks for Codex/Cursor Apr 16, 2026

claude Bot reviewed Apr 16, 2026

View reviewed changes

Comment thread CLAUDE.md Outdated

nithinraok previously approved these changes Apr 16, 2026

View reviewed changes

Fix truncated sentence

2c1562f

Signed-off-by: Piotr Żelasko <petezor@gmail.com>

pzelasko dismissed nithinraok’s stale review via 2c1562f April 16, 2026 17:07

chtruong814 added Run CICD and removed Run CICD labels Apr 16, 2026

chtruong814 had a problem deploying to test April 16, 2026 17:09 — with GitHub Actions Error

pzelasko added Run CICD and removed Run CICD labels Apr 16, 2026

pzelasko temporarily deployed to test April 16, 2026 17:11 — with GitHub Actions Inactive

github-actions Bot removed the Run CICD label Apr 16, 2026

Make babysitter less autonomous

1d07a8c

Signed-off-by: Piotr Żelasko <petezor@gmail.com>

chtruong814 reviewed Apr 16, 2026

View reviewed changes

chtruong814 approved these changes Apr 17, 2026

View reviewed changes

pzelasko merged commit b1cb6de into main Apr 17, 2026
125 checks passed

pzelasko deleted the agents-md-claude-md branch April 17, 2026 23:39

	"type": "command",
	"command": "jq -r '.tool_input.file_path' \| { read -r f; f=\"${f#\"$(git rev-parse --show-toplevel)/\"}\"; case \"$f\" in .py) ;; ) exit 0;; esac; case \"$f\" in docs/\|external/\|examples/) exit 0;; nemo/collections/speechlm2/) ;; nemo/collections/*) exit 0;; esac; black --quiet \"$f\"; isort --quiet \"$f\"; } 2>/dev/null \|\| true",

Conversation

pzelasko commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do ?

Changelog

Usage

GitHub Actions CI

Before your PR is "Ready for review"

Who can review?

Additional Information

Uh oh!

pzelasko commented Apr 15, 2026

Uh oh!

claude Bot Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

vmendelev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pzelasko commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

nithinraok commented Apr 16, 2026

Uh oh!

Uh oh!

nithinraok left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

pzelasko commented Apr 16, 2026

Uh oh!

chtruong814 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pzelasko commented Apr 17, 2026

Uh oh!

pzelasko commented Apr 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pzelasko commented Apr 15, 2026 •

edited

Loading