Skip to content

Add script to check for lines exceeding 119 characters#15625

Closed
Pritiks23 wants to merge 2 commits into
NVIDIA-NeMo:mainfrom
Pritiks23:main
Closed

Add script to check for lines exceeding 119 characters#15625
Pritiks23 wants to merge 2 commits into
NVIDIA-NeMo:mainfrom
Pritiks23:main

Conversation

@Pritiks23
Copy link
Copy Markdown

What does this PR do ?

Adds a utility script to check if any lines in a file exceed the 119-character line length limit.

Collection: common (scripts/utility)

Collection: [Note which collection this PR will affect]

Changelog

Added check_line_length.py to check for lines exceeding 119 characters in files or directories.

Usage

  • You can potentially add a usage example below
python scripts/check_line_length.py <file_or_directory>
python scripts/check_line_length.py nemo/

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • [ Y] Make sure you read and followed Contributor guidelines
  • [ Y] Did you write any new necessary tests?
  • [Y ] Did you add or update any necessary documentation?
  • [ N] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • [ Y] New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Pritiks23 and others added 2 commits April 20, 2026 12:32
@pzelasko
Copy link
Copy Markdown
Collaborator

Thanks but we already have formatting checks and pre-commit hooks for these things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants