Attentionpooling ecapa #2468
Merged
Attentionpooling ecapa #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nithinraok
commented
Jul 12, 2021
•
nithinraok
commented
- Adds new modified ecapa ecoder for better speaker embeddings
- adds attention pooling decoder
- adds TAP pooling
- tests
|
This pull request introduces 1 alert when merging 673b918 into 44a3d02 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 558f948 into 44a3d02 - view on LGTM.com new alerts:
|
titu1994
requested changes
Jul 13, 2021
| 'cls': 'nemo.collections.asr.modules.ECAPA_Encoder', | ||
| 'params': { | ||
| 'feat_in': 80, | ||
| 'filters': [1024, 1024, 1024, 1024, 3072], |
There was a problem hiding this comment.
Dont use such large filters for tests, it will slow it down.
nithinraok
force-pushed
the
attentionpooling_ecapa
branch
from
83e7da7
to
cc113bc
Compare
titu1994
requested changes
Jul 14, 2021
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
nithinraok
force-pushed
the
attentionpooling_ecapa
branch
from
cc113bc
to
6c4d51d
Compare
titu1994
approved these changes
Jul 14, 2021
fayejf
pushed a commit
that referenced
this pull request
Jul 16, 2021
* initial_draft Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * group_fix Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * tdnn_block_name_change Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * no masking Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * mask update Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * attentive masking Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * speakernet_name Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * added tests and doc strings Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * added ecapa yaml Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * test and unused variable fix Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * case change and review feedback fixes Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * updated name Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
titu1994
pushed a commit
to titu1994/NeMo
that referenced
this pull request
Jul 20, 2021
* initial_draft Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * group_fix Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * tdnn_block_name_change Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * no masking Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * mask update Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * attentive masking Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * speakernet_name Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * added tests and doc strings Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * added ecapa yaml Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * test and unused variable fix Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * case change and review feedback fixes Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * updated name Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
paarthneekhara
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Sep 17, 2021
* initial_draft Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * group_fix Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * tdnn_block_name_change Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * no masking Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * mask update Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * attentive masking Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * speakernet_name Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * added tests and doc strings Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * added ecapa yaml Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * test and unused variable fix Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * case change and review feedback fixes Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * updated name Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> Signed-off-by: Paarth Neekhara <paarth.n@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.