Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NMT method to translate with TN/ITN pre/post-processing #4009

Merged
merged 14 commits into from
Apr 15, 2022

Conversation

MaximumEntropy
Copy link
Contributor

What does this PR do ?

Adds a method to NMT to apply ITN/TN before/after translating text.

Collection: NLP

Changelog

  • Adds an itn_translate_tn method to mt_enc_dec_model.

Usage

inverse_normalizer = InverseNormalizer(lang="en")
normalizer = Normalizer(input_case="cased", lang="de")
translation_model.itn_translate_tn(["this is a sentence"], "en", "de", inverse_normalizer=inverse_normalizer, normalizer=normalizer)

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Copy link
Collaborator

@aklife97 aklife97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this!

@aklife97 aklife97 merged commit a1c2d4e into main Apr 15, 2022
@aklife97 aklife97 deleted the tn_itn_translate branch April 15, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants