-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove transformer version upper bound #5831
Conversation
Issue in CI due to typo in transformers v4.25.1 see issue raised huggingface/transformers#21204 |
Issue has been fixed and merged into main by Huggingface at huggingface/transformers#21207 As a note, the PR author noted: ALL_PRETRAINED_CONFIG_ARCHIVE_MAP is deprecated and will be removed in v5 of Transformers. There are a couple of places that we import this such as
I think we should pre-emptively fix this (perhaps in this PR) as this is going to be a breaking change for us. |
specifically ALL_PRETRAINED_CONFIG_ARCHIVE_MAP Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>
Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
* remove transformer version upper bound * Temporarily disable Huggingface NMT steps * re-enable NMT with huggingface * remove transformers v5 deprecated constant specifically ALL_PRETRAINED_CONFIG_ARCHIVE_MAP Signed-off-by: Zhilin Wang <zhilinw@nvidia.com> * remove deprecated HF NMT from jenkinsfile Signed-off-by: Zhilin Wang <zhilinw@nvidia.com> Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>
* remove transformer version upper bound * Temporarily disable Huggingface NMT steps * re-enable NMT with huggingface * remove transformers v5 deprecated constant specifically ALL_PRETRAINED_CONFIG_ARCHIVE_MAP Signed-off-by: Zhilin Wang <zhilinw@nvidia.com> * remove deprecated HF NMT from jenkinsfile Signed-off-by: Zhilin Wang <zhilinw@nvidia.com> Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>
* remove transformer version upper bound * Temporarily disable Huggingface NMT steps * re-enable NMT with huggingface * remove transformers v5 deprecated constant specifically ALL_PRETRAINED_CONFIG_ARCHIVE_MAP Signed-off-by: Zhilin Wang <zhilinw@nvidia.com> * remove deprecated HF NMT from jenkinsfile Signed-off-by: Zhilin Wang <zhilinw@nvidia.com> Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>
* remove transformer version upper bound * Temporarily disable Huggingface NMT steps * re-enable NMT with huggingface * remove transformers v5 deprecated constant specifically ALL_PRETRAINED_CONFIG_ARCHIVE_MAP Signed-off-by: Zhilin Wang <zhilinw@nvidia.com> * remove deprecated HF NMT from jenkinsfile Signed-off-by: Zhilin Wang <zhilinw@nvidia.com> Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>
* remove transformer version upper bound * Temporarily disable Huggingface NMT steps * re-enable NMT with huggingface * remove transformers v5 deprecated constant specifically ALL_PRETRAINED_CONFIG_ARCHIVE_MAP Signed-off-by: Zhilin Wang <zhilinw@nvidia.com> * remove deprecated HF NMT from jenkinsfile Signed-off-by: Zhilin Wang <zhilinw@nvidia.com> Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>
What does this PR do ?
remove transformer version upper bound
Collection: nlp, asr, tts
Changelog
Usage
# Add a code snippet demonstrating how to use this
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information