Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove transformer version upper bound #5831

Merged
merged 6 commits into from
Jan 20, 2023

Conversation

Zhilin123
Copy link
Collaborator

@Zhilin123 Zhilin123 commented Jan 19, 2023

What does this PR do ?

remove transformer version upper bound

Collection: nlp, asr, tts

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@Zhilin123
Copy link
Collaborator Author

Issue in CI due to typo in transformers v4.25.1 see issue raised huggingface/transformers#21204

@Zhilin123
Copy link
Collaborator Author

Issue has been fixed and merged into main by Huggingface at huggingface/transformers#21207

As a note, the PR author noted:

ALL_PRETRAINED_CONFIG_ARCHIVE_MAP is deprecated and will be removed in v5 of Transformers.

There are a couple of places that we import this such as

  File "/usr/local/lib/python3.8/dist-packages/nemo/collections/nlp/modules/common/huggingface/huggingface_utils.py", line 151, in get_huggingface_pretrained_lm_models_list

    huggingface_models = list(ALL_PRETRAINED_CONFIG_ARCHIVE_MAP.keys())

I think we should pre-emptively fix this (perhaps in this PR) as this is going to be a breaking change for us.

@github-actions github-actions bot removed the CI label Jan 20, 2023
specifically ALL_PRETRAINED_CONFIG_ARCHIVE_MAP

Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>
Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>
@github-actions github-actions bot added the CI label Jan 20, 2023
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Zhilin123 Zhilin123 merged commit a7ed727 into main Jan 20, 2023
@Zhilin123 Zhilin123 deleted the remove_transformer_version_upperbound branch January 20, 2023 20:52
Kipok pushed a commit to Kipok/NeMo that referenced this pull request Jan 31, 2023
* remove transformer version upper bound

* Temporarily disable Huggingface NMT steps

* re-enable NMT with huggingface

* remove transformers v5 deprecated constant

specifically ALL_PRETRAINED_CONFIG_ARCHIVE_MAP

Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>

* remove deprecated HF NMT from jenkinsfile

Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>

Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>
ericharper pushed a commit that referenced this pull request Jan 31, 2023
* remove transformer version upper bound

* Temporarily disable Huggingface NMT steps

* re-enable NMT with huggingface

* remove transformers v5 deprecated constant

specifically ALL_PRETRAINED_CONFIG_ARCHIVE_MAP

Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>

* remove deprecated HF NMT from jenkinsfile

Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>

Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>
ericharper pushed a commit that referenced this pull request Jan 31, 2023
* remove transformer version upper bound

* Temporarily disable Huggingface NMT steps

* re-enable NMT with huggingface

* remove transformers v5 deprecated constant

specifically ALL_PRETRAINED_CONFIG_ARCHIVE_MAP

Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>

* remove deprecated HF NMT from jenkinsfile

Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>

Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>
Kipok pushed a commit to Kipok/NeMo that referenced this pull request Jan 31, 2023
* remove transformer version upper bound

* Temporarily disable Huggingface NMT steps

* re-enable NMT with huggingface

* remove transformers v5 deprecated constant

specifically ALL_PRETRAINED_CONFIG_ARCHIVE_MAP

Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>

* remove deprecated HF NMT from jenkinsfile

Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>

Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
* remove transformer version upper bound

* Temporarily disable Huggingface NMT steps

* re-enable NMT with huggingface

* remove transformers v5 deprecated constant

specifically ALL_PRETRAINED_CONFIG_ARCHIVE_MAP

Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>

* remove deprecated HF NMT from jenkinsfile

Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>

Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants