Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace symbols #5974

Merged
merged 2 commits into from
Feb 10, 2023
Merged

replace symbols #5974

merged 2 commits into from
Feb 10, 2023

Conversation

nithinraok
Copy link
Collaborator

Signed-off-by: nithinraok nithinrao.koluguri@gmail.com

What does this PR do ?

Fix Summary name {} is illegal; using {} instead warning
Collection: [ASR]

Changelog

  • replace @ with _

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@nithinraok
replace symbols
bbd20db 
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
@github-actions github-actions bot added the ASR label Feb 9, 2023
@nithinraok nithinraok merged commit 83421b5 into r1.16.0 Feb 10, 2023
@nithinraok nithinraok deleted the replace_logging_name branch February 10, 2023 17:34
github-actions bot pushed a commit that referenced this pull request Feb 10, 2023
@nithinraok @web-flow
replace symbols (#5974)
da8312d 
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
nithinraok added a commit that referenced this pull request Feb 10, 2023
@github-actions @nithinraok
replace symbols (#5974) (#5990)
bfd371d 
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com>
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
@github-actions @nithinraok @titu1994
replace symbols (NVIDIA#5974) (NVIDIA#5990)
f4607e7 
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titu1994 titu1994 titu1994 approved these changes

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

Assignees
No one assigned
Labels
ASR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nithinraok @titu1994