Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set TE flag in legacy -> mcore conversion script #9722

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

terrykong
Copy link
Collaborator

Same as #9585, but into release branch

cuichenx and others added 2 commits July 1, 2024 14:30
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: cuichenx <cuichenx@users.noreply.github.com>
@terrykong terrykong requested a review from cuichenx July 12, 2024 16:59
@ericharper ericharper merged commit 0ec7e90 into r2.0.0rc1 Jul 12, 2024
122 checks passed
@ericharper ericharper deleted the chcui/mcore_conversion_small_fix branch July 12, 2024 17:05
@cuichenx
Copy link
Collaborator

#9585 was merged to the main branch two weeks ago so the release branch should already have the commit?

@terrykong
Copy link
Collaborator Author

@cuichenx You're right, I'm actually surprised github said we could make this MR. When I look at the 0ec7e90 commit history for that conversion script it actually doesn't even show this commit. So the git history on the conversion script looks okay:

image

@ko3n1g ko3n1g mentioned this pull request Jul 18, 2024
2 tasks
dimapihtar pushed a commit that referenced this pull request Aug 27, 2024
* set TE flag

Signed-off-by: Chen Cui <chcui@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: cuichenx <cuichenx@users.noreply.github.com>

---------

Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: cuichenx <cuichenx@users.noreply.github.com>
Co-authored-by: Chen Cui <chcui@nvidia.com>
Co-authored-by: cuichenx <cuichenx@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants