Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding error handling for non-existent parse file arg #21

Merged
merged 1 commit into from May 27, 2020

Conversation

alexminnaar
Copy link
Contributor

@alexminnaar alexminnaar commented May 23, 2020

Hello and thank you for the great tool. I noticed that if you run parse.py on a nonexistent file like

python -m pyprof.parse non_existent_file.sqlite > net.dict

there is no error thrown and net.dict contains no such table: CUPTI_ACTIVITY_KIND_KERNEL. I added very simple error handling for the case of a non-existent input file.

Signed-off-by: Alex Minnaar minnaaralex@gmail.com

Signed-off-by: Alex Minnaar <minnaaralex@gmail.com>
Copy link
Contributor

@debermudez debermudez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

@debermudez debermudez merged commit 0176a91 into NVIDIA:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants