Add build configured torchfort_config.h header to indicate GPU support in build. #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current
torchfort.handtorchfort_rl.hheader files use#ifdef ENABLE_GPUpreprocessor macros to control whethercudaStream_tis redefined to enable CPU only builds. The issue is that this macro is only defined when building the library, so users building external applications with CUDA can run into problems when including these headers. In particular, if they don't also defineENABLE_GPUin their compilation, they will run into redefinition errors.For example, compiling the following program:
using a typical compilation line like:
results in the following error:
which can be resolved by adding
-DENABLE_GPUto the compile line, which is not great user experience.To fix this, this PR introduces a build time created
torch_config.hwhich will defineTORCHFORT_ENABLE_GPUto indicate whether TorchFort was built with GPU support or not. This configuration header is then included intorchfort.handtorchfort_rl.hto control whethercudaStream_tis redefined or not, removing the need for users to defineENABLE_GPUthemselves anymore.