From d145fd66d7b23dbd48cad9477ff5420d3c701b52 Mon Sep 17 00:00:00 2001 From: Masaki Kozuki Date: Sun, 10 May 2026 09:38:25 +0900 Subject: [PATCH] Remove NCCL>=2.10.3 check as 2.10.3 was released in 2021 April. ref: https://docs.nvidia.com/deeplearning/nccl/archives/nccl_2303/release-notes/rel_2-10-3.html Signed-off-by: Masaki Kozuki --- setup.py | 32 +++++++++----------------------- 1 file changed, 9 insertions(+), 23 deletions(-) diff --git a/setup.py b/setup.py index 32b218d0d..2a70a7e78 100644 --- a/setup.py +++ b/setup.py @@ -869,30 +869,16 @@ def check_cudnn_version_and_warn(global_option: str, required_cudnn_version: int if "--nccl_p2p" in sys.argv: sys.argv.remove("--nccl_p2p") raise_if_cuda_home_none("--nccl_p2p") - # Check NCCL version. - _nccl_version_getter = load( - name="_nccl_version_getter", - sources=[ - "apex/contrib/csrc/nccl_p2p/nccl_version.cpp", - "apex/contrib/csrc/nccl_p2p/nccl_version_check.cu", - ], - ) - _available_nccl_version = _nccl_version_getter.get_nccl_version() - if _available_nccl_version >= (2, 10): - ext_modules.append( - CUDAExtension( - name="nccl_p2p_cuda", - sources=[ - "apex/contrib/csrc/nccl_p2p/nccl_p2p_cuda.cu", - "apex/contrib/csrc/nccl_p2p/nccl_p2p.cpp", - ], - extra_compile_args={"cxx": ["-O3"] + generator_flag}, - ) - ) - else: - warnings.warn( - f"Skip `--nccl_p2p` as it requires NCCL 2.10.3 or later, but {_available_nccl_version[0]}.{_available_nccl_version[1]}" + ext_modules.append( + CUDAExtension( + name="nccl_p2p_cuda", + sources=[ + "apex/contrib/csrc/nccl_p2p/nccl_p2p_cuda.cu", + "apex/contrib/csrc/nccl_p2p/nccl_p2p.cpp", + ], + extra_compile_args={"cxx": ["-O3"] + generator_flag}, ) + ) # note (mkozuki): Now `--fast_bottleneck` option (i.e. apex/contrib/bottleneck) depends on `--peer_memory` and `--nccl_p2p`. if has_flag("--fast_bottleneck", "APEX_FAST_BOTTLENECK"):