Skip to content

Conversation

@leofang
Copy link
Member

@leofang leofang commented Oct 28, 2025

Description

I exclude mentioning the IPC event in case we want to make last-minute changes.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copilot AI and others added 3 commits October 28, 2025 20:17
@leofang leofang added this to the cuda.core beta 8 milestone Oct 28, 2025
@leofang leofang requested review from Andy-Jost and rparolin October 28, 2025 21:32
@leofang leofang self-assigned this Oct 28, 2025
@leofang leofang added documentation Improvements or additions to documentation P0 High priority - Must do! packaging Anything related to wheels or Conda packages cuda.core Everything related to the cuda.core module labels Oct 28, 2025
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Oct 28, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang
Copy link
Member Author

leofang commented Oct 28, 2025

/ok to test 5e99554

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR prepares the cuda.core package for a v0.4.1 patch release by updating version identifiers and adding release notes. The changes update the package version from 0.4.0 to 0.4.1 in the source code, register the new version in the documentation versioning manifest, and create release notes documenting five bug fixes (segfault, type limits, documentation rendering, version requirements, and test flakiness). The patch release contains no breaking changes or new features, following standard semantic versioning practices. The documentation infrastructure will serve the new version at https://nvidia.github.io/cuda-python/cuda-core/0.4.1/, maintaining the existing versioning structure alongside previous releases.

Important Files Changed

Filename Score Overview
cuda_core/cuda/core/_version.py 5/5 Version string bumped from "0.4.0" to "0.4.1" for patch release
cuda_core/docs/nv-versions.json 5/5 New documentation version entry added for v0.4.1 with proper URL mapping
cuda_core/docs/source/release/0.4.1-notes.rst 4/5 Release notes added documenting five bug fixes with one typo ("redendering")

Confidence score: 4/5

  • This PR is safe to merge with only minor documentation issues requiring attention
  • Score reflects a typo in the release notes ("redendering" should be "rendering") and a release date of Oct 29, 2025 that is one day in the future from the current date (Oct 28, 2025), which may be intentional for a scheduled release but should be verified
  • Pay close attention to cuda_core/docs/source/release/0.4.1-notes.rst line 41 for the typo correction before merging

Sequence Diagram

sequenceDiagram
    participant Developer
    participant Version File
    participant Documentation Config
    participant Release Notes
    
    Developer->>Version File: "Update __version__ to 0.4.1"
    Developer->>Documentation Config: "Add version 0.4.1 entry with URL"
    Developer->>Release Notes: "Create 0.4.1-notes.rst with fixes"
    Note over Version File,Release Notes: Prepare v0.4.1 patch release
Loading

3 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@leofang
Copy link
Member Author

leofang commented Oct 28, 2025

/ok to test 22be255

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This review covers only the changes made since the last review, not the entire PR. The most recent change corrects a typo in the v0.4.1 release notes file, changing "redendering" to "rendering" in the documentation fix entry. This is a simple spelling correction in the release notes that document a bug fix for VirtualMemoryResourceOptions documentation rendering. The change is part of the v0.4.1 patch release preparation for the cuda.core package, which contains only bug fixes with no breaking changes or new features. The corrected line now accurately describes the documentation fix that was implemented.

Important Files Changed

Filename Score Overview
cuda_core/docs/source/release/0.4.1-notes.rst 5/5 Corrected typo in release notes documentation from "redendering" to "rendering"

Confidence score: 5/5

  • This PR is safe to merge with no risk of production issues
  • Score reflects a simple typo correction in documentation-only release notes with zero functional impact
  • No files require special attention; this is a straightforward documentation spelling fix

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@github-actions

This comment has been minimized.

rparolin
rparolin previously approved these changes Oct 28, 2025
@leofang leofang merged commit 453577d into NVIDIA:main Oct 28, 2025
1 check was pending
@leofang leofang deleted the copilot/bump-version-to-041 branch October 28, 2025 22:31
@github-actions
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.core Everything related to the cuda.core module documentation Improvements or additions to documentation P0 High priority - Must do! packaging Anything related to wheels or Conda packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants