-
Notifications
You must be signed in to change notification settings - Fork 221
Prepare for v0.4.1 patch release #1195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>
|
/ok to test 5e99554 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Greptile Summary
This PR prepares the cuda.core package for a v0.4.1 patch release by updating version identifiers and adding release notes. The changes update the package version from 0.4.0 to 0.4.1 in the source code, register the new version in the documentation versioning manifest, and create release notes documenting five bug fixes (segfault, type limits, documentation rendering, version requirements, and test flakiness). The patch release contains no breaking changes or new features, following standard semantic versioning practices. The documentation infrastructure will serve the new version at https://nvidia.github.io/cuda-python/cuda-core/0.4.1/, maintaining the existing versioning structure alongside previous releases.
Important Files Changed
| Filename | Score | Overview |
|---|---|---|
| cuda_core/cuda/core/_version.py | 5/5 | Version string bumped from "0.4.0" to "0.4.1" for patch release |
| cuda_core/docs/nv-versions.json | 5/5 | New documentation version entry added for v0.4.1 with proper URL mapping |
| cuda_core/docs/source/release/0.4.1-notes.rst | 4/5 | Release notes added documenting five bug fixes with one typo ("redendering") |
Confidence score: 4/5
- This PR is safe to merge with only minor documentation issues requiring attention
- Score reflects a typo in the release notes ("redendering" should be "rendering") and a release date of Oct 29, 2025 that is one day in the future from the current date (Oct 28, 2025), which may be intentional for a scheduled release but should be verified
- Pay close attention to cuda_core/docs/source/release/0.4.1-notes.rst line 41 for the typo correction before merging
Sequence Diagram
sequenceDiagram
participant Developer
participant Version File
participant Documentation Config
participant Release Notes
Developer->>Version File: "Update __version__ to 0.4.1"
Developer->>Documentation Config: "Add version 0.4.1 entry with URL"
Developer->>Release Notes: "Create 0.4.1-notes.rst with fixes"
Note over Version File,Release Notes: Prepare v0.4.1 patch release
3 files reviewed, 1 comment
|
/ok to test 22be255 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Greptile Summary
This review covers only the changes made since the last review, not the entire PR. The most recent change corrects a typo in the v0.4.1 release notes file, changing "redendering" to "rendering" in the documentation fix entry. This is a simple spelling correction in the release notes that document a bug fix for VirtualMemoryResourceOptions documentation rendering. The change is part of the v0.4.1 patch release preparation for the cuda.core package, which contains only bug fixes with no breaking changes or new features. The corrected line now accurately describes the documentation fix that was implemented.
Important Files Changed
| Filename | Score | Overview |
|---|---|---|
| cuda_core/docs/source/release/0.4.1-notes.rst | 5/5 | Corrected typo in release notes documentation from "redendering" to "rendering" |
Confidence score: 5/5
- This PR is safe to merge with no risk of production issues
- Score reflects a simple typo correction in documentation-only release notes with zero functional impact
- No files require special attention; this is a straightforward documentation spelling fix
1 file reviewed, 1 comment
This comment has been minimized.
This comment has been minimized.
|
Description
I exclude mentioning the IPC event in case we want to make last-minute changes.
Checklist