Skip to content

Comments

Fix performance hint warnings raised by Cython 3#538

Merged
leofang merged 8 commits intoNVIDIA:mainfrom
leofang:fix_warning
Apr 4, 2025
Merged

Fix performance hint warnings raised by Cython 3#538
leofang merged 8 commits intoNVIDIA:mainfrom
leofang:fix_warning

Conversation

@leofang
Copy link
Member

@leofang leofang commented Mar 29, 2025

  • For changes in nvJitLink/NVVM, please see internal codegen (MR 110)
  • For changes in cudart, please see internal codegen (MR 41)

@leofang leofang added this to the cuda-python 12.9.0 & 11.8.7 milestone Mar 29, 2025
@leofang leofang self-assigned this Mar 29, 2025
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Mar 29, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang leofang changed the title WIP: Fix performance hit warnings raised by Cython 3 Fix performance hit warnings raised by Cython 3 Apr 1, 2025
@leofang leofang marked this pull request as ready for review April 1, 2025 04:42
@leofang leofang requested review from rwgk and vzhurba01 April 1, 2025 04:42
@leofang leofang added enhancement Any code-related improvements P1 Medium priority - Should do cuda.bindings Everything related to the cuda.bindings module labels Apr 1, 2025
@leofang
Copy link
Member Author

leofang commented Apr 1, 2025

/ok to test

@github-actions

This comment has been minimized.

@leofang leofang changed the title Fix performance hit warnings raised by Cython 3 Fix performance hint warnings raised by Cython 3 Apr 1, 2025
vzhurba01
vzhurba01 previously approved these changes Apr 1, 2025
kkraus14
kkraus14 previously approved these changes Apr 2, 2025
@leofang
Copy link
Member Author

leofang commented Apr 4, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Apr 4, 2025

Admin-merge since it's been approved and all CIs are green after resolving merge conflicts.

@leofang leofang merged commit 5b49da6 into NVIDIA:main Apr 4, 2025
73 checks passed
@leofang leofang deleted the fix_warning branch April 4, 2025 20:06
@github-actions
Copy link

github-actions bot commented Apr 4, 2025

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements P1 Medium priority - Should do

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants