Remove --enable-mlir (hasn't been needed for a while)#586
Merged
Conversation
Signed-off-by: Ben Howe <bhowe@nvidia.com>
bmhowe23
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparing for NVIDIA/cuda-quantum#4655
The above PR removes support for the flag, but the default of enabling MLIR has been the default for quite some time now, so the changes in this PR should have no effect, even if they are merged before 4655.
Normally changes to docs and examples would need to wait for a release to occur first, but since these changes are backwards compatible with older versions of nvq++, this isn't necessary.