test skills#1264
Closed
rgsl888prabhu wants to merge 2 commits into
Closed
Conversation
Add SPDX-FileCopyrightText / SPDX-License-Identifier headers (Apache-2.0) to markdown files in the cuopt-routing-api-python and routing-formulation skills.
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
rgsl888prabhu
added
non-breaking
Collaborator
Author
|
/nvskills-ci |
📝 WalkthroughWalkthroughAdds SPDX copyright/Apache-2.0 header blocks to multiple skill documentation files, updates small wording and reference links in two skill-card.md files, and replaces the DSSE payloads/signatures in two skill.oms.sig Sigstore bundles. ChangesDocumentation and skill-card edits
Sigstore bundle updates
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
skills/routing-formulation/SKILL.md (1)
1-10: Ensure NVSkills CI validation before merge.All changes in this PR modify files under the
skills/directory. As per coding guidelines, these changes must be validated by NVSkills CI before merge.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/routing-formulation/SKILL.md` around lines 1 - 10, This PR changes files under skills; before merging ensure the NVSkills CI pipeline runs and passes—update the PR checklist / CI configuration so NVSkills validation is triggered for the skill named "routing-formulation" (version "26.06.00") and confirm all NVSkills CI checks complete successfully; if NVSkills config is missing or excludes the skills/ path, add or correct the CI trigger so changes under skills/ invoke the NVSkills validation step.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@skills/routing-formulation/SKILL.md`:
- Around line 1-10: This PR changes files under skills; before merging ensure
the NVSkills CI pipeline runs and passes—update the PR checklist / CI
configuration so NVSkills validation is triggered for the skill named
"routing-formulation" (version "26.06.00") and confirm all NVSkills CI checks
complete successfully; if NVSkills config is missing or excludes the skills/
path, add or correct the CI trigger so changes under skills/ invoke the NVSkills
validation step.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: eeb267ea-fe7b-4007-bc3b-6305d6ed27ee
📒 Files selected for processing (9)
skills/cuopt-routing-api-python/SKILL.mdskills/cuopt-routing-api-python/assets/README.mdskills/cuopt-routing-api-python/assets/pdp_basic/README.mdskills/cuopt-routing-api-python/assets/vrp_basic/README.mdskills/cuopt-routing-api-python/resources/examples.mdskills/cuopt-routing-api-python/resources/server_examples.mdskills/cuopt-routing-api-python/skill-card.mdskills/routing-formulation/SKILL.mdskills/routing-formulation/skill-card.md
Collaborator
Author
|
/nvskills-ci |
1 similar comment
Collaborator
Author
|
/nvskills-ci |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
skills/cuopt-routing-api-python/skill-card.md (1)
1-41:⚠️ Potential issue | 🟠 MajorNVSkills CI not passing for skills/ PR—block merge until it runs successfully
- PR
#1264shows “Request NVSkills CI” = SKIPPED and no NVSkills-related status check is present instatusCheckRollup; NVSkills CI validation isn’t complete forskills/cuopt-routing-api-python/skill-card.md.- Ensure NVSkills CI runs and passes before merging.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/cuopt-routing-api-python/skill-card.md` around lines 1 - 41, The NVSkills CI did not run for this PR (Request NVSkills CI = SKIPPED), so trigger and ensure the NVSkills validation completes and passes before merging; re-run the pipeline for PR `#1264` (or rebase/commit to re-trigger checks), confirm the NVSkills-related status check appears in the statusCheckRollup and shows a successful/pass result, and only then proceed with merge of the skill-card.md changes.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@skills/cuopt-routing-api-python/skill-card.md`:
- Around line 1-41: The NVSkills CI did not run for this PR (Request NVSkills CI
= SKIPPED), so trigger and ensure the NVSkills validation completes and passes
before merging; re-run the pipeline for PR `#1264` (or rebase/commit to re-trigger
checks), confirm the NVSkills-related status check appears in the
statusCheckRollup and shows a successful/pass result, and only then proceed with
merge of the skill-card.md changes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 5ce9da49-08ad-4bb5-986a-baa8b9165254
📒 Files selected for processing (4)
skills/cuopt-routing-api-python/skill-card.mdskills/cuopt-routing-api-python/skill.oms.sigskills/routing-formulation/skill-card.mdskills/routing-formulation/skill.oms.sig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test skills