Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override build date with SOURCE_DATE_EPOCH #94

Closed
wants to merge 1 commit into from

Conversation

bmwiedemann
Copy link
Contributor

@bmwiedemann bmwiedemann commented Jun 25, 2020

Allow to override build date with SOURCE_DATE_EPOCH
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

This date call only works with GNU date.

Without this patch, I got such diff:

/usr/lib64/libnvidia-container.so.1.1.1 differs in ELF section .rodata
@@ -106,8 +106,8 @@
  13650 73656c66 2f6e732f 25730073 7472696e  self/ns/%s.strin
  13660 6720666f 726d6174 74696e67 20666169  g formatting fai
  13670 6c656400 312e312e 31007665 7273696f  led.1.1.1.versio
- 13680 6e3a2025 730a0032 3032302d 30362d32  n: %s..2020-06-2
- 13690 34543136 3a35332b 30303a30 30006275  4T16:53+00:00.bu
+ 13680 6e3a2025 730a0032 3033352d 30372d32  n: %s..2035-07-2
+ 13690 38543036 3a30392b 30303a30 30006275  8T06:09+00:00.bu
  136a0 696c6420 64617465 3a202573 0a006275  ild date: %s..bu

And with the patch, we can do bit-reproducible package builds of libnvidia-container.

This PR was done while working on reproducible builds for openSUSE.

in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

This date call only works with GNU date.

Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de>
@bmwiedemann
Copy link
Contributor Author

I'd still like to see this merged. Is there anything left to do? Something I can help with?

@elezar
Copy link
Member

elezar commented Jan 18, 2021

Hello There!

Thanks for your contribution!
This repository is a read-only mirror of the following repository: https://gitlab.com/nvidia/container-toolkit/libnvidia-container

Do you mind:

Thanks again!

(sorry for the delay in responding. Our bot that should have responded automatically was down for a bit)

@bmwiedemann
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants